particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

return xmlrpc-compatible list instead of set

Browse source
This commit is contained in:
Tomas Kopecek 2017-10-31 13:36:03 +01:00 • committed by Mike McLean
parent f40fee4b7d
commit 921fcae6fe
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hub/kojihub.py
View file

@ -7305,7 +7305,7 @@ def get_notification_recipients(build, tag_id, state):
#FIXME - if tag_id is None, we don't have a good way to get the package owner.
# using all package owners from all tags would be way overkill.
return set(emails)
return list(set(emails))
def tag_notification(is_successful, tag_id, from_id, build_id, user_id, ignore_success=False, failure_msg=''):
if context.opts.get('DisableNotifications'):

10
tests/test_hub/test_notifications.py
View file

@ -37,7 +37,7 @@ class TestGetNotificationRecipients(unittest.TestCase):
state = koji.BUILD_STATES['CANCELED']
emails = kojihub.get_notification_recipients(build, tag_id, state)
self.assertEqual(emails, set([]))
self.assertEqual(emails, [])
# only query to watchers
self.assertEqual(len(self.queries), 1)
@ -61,7 +61,7 @@ class TestGetNotificationRecipients(unittest.TestCase):
self.queries = []
emails = kojihub.get_notification_recipients(build, tag_id, state)
self.assertEqual(emails, set(['owner_name@test.domain.com']))
self.assertEqual(emails, ['owner_name@test.domain.com'])
# there should be only query to watchers
self.assertEqual(len(self.queries), 1)
@ -104,7 +104,7 @@ class TestGetNotificationRecipients(unittest.TestCase):
}
emails = kojihub.get_notification_recipients(build, tag_id, state)
self.assertEqual(emails, set(['owner_name@test.domain.com', 'pkg_owner_name@test.domain.com']))
self.assertEqual(emails, ['owner_name@test.domain.com', 'pkg_owner_name@test.domain.com'])
# there should be only query to watchers
@ -133,7 +133,7 @@ class TestGetNotificationRecipients(unittest.TestCase):
'usertype': koji.USERTYPES['NORMAL']
}
emails = kojihub.get_notification_recipients(build, tag_id, state)
self.assertEqual(emails, set(['owner_name@test.domain.com']))
self.assertEqual(emails, ['owner_name@test.domain.com'])
# package owner is machine
get_user.return_value = {
@ -143,4 +143,4 @@ class TestGetNotificationRecipients(unittest.TestCase):
'usertype': koji.USERTYPES['HOST']
}
emails = kojihub.get_notification_recipients(build, tag_id, state)
self.assertEqual(emails, set(['owner_name@test.domain.com']))
self.assertEqual(emails, ['owner_name@test.domain.com'])