Emulate old list data

koji/rpmdiff.py

@@ -231,12 +231,30 @@ class Rpmdiff:
             return self.__fileIteratorToDict(hdr.fiFromHeader())
         result = {}
         for file in rpm.files(hdr):
-            result[file.name] = file
+            # mimic old fi order because comparison and kojihash relies on it
+            # (FN, FSize, FMode, FMtime, FFlags, FRdev, FInode, FNlink, FState, VFlags, FUser, FGroup, Digest)
+            filedata = [
+                    # name omitted
+                    file.size,
+                    file.mode,
+                    file.mtime,
+                    file.fflags,
+                    file.rdev,
+                    file.inode,
+                    file.nlink,
+                    file.state,
+                    file.vflags,
+                    file.user,
+                    file.group,
+                    file.digest,
+                    ]
+            result[file.name] = filedata
         return result
 
     def __fileIteratorToDict(self, fi):
         result = {}
         for filedata in fi:
+            # index by name
             result[filedata[0]] = list(filedata[1:])
         return result