From b04396d333870738b7ed0dbf32f64e4dc82fd3a0 Mon Sep 17 00:00:00 2001
From: Yuming Zhu <yzhu@redhat.com>
Date: Tue, 22 Oct 2024 23:07:53 +0800
Subject: [PATCH] fix removeNonprintable for PY2

---
 koji/__init__.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/koji/__init__.py b/koji/__init__.py
index 39ee74c9..99667475 100644
--- a/koji/__init__.py
+++ b/koji/__init__.py
@@ -3825,13 +3825,14 @@ if six.PY3:
 
 
 def removeNonprintable(value):
+    # TODO: it's no more used in PY2
     # expects raw-encoded string, not unicode
     if six.PY2:
-        value = value.translate(None, NONPRINTABLE_CHARS)
+        return value.translate(None, NONPRINTABLE_CHARS)
     else:
         value = value.translate(NONPRINTABLE_CHARS_TABLE)
-    # remove broken unicode chars (some changelogs, etc.)
-    return value.encode('utf-8', errors='replace').decode()
+        # remove broken unicode chars (some changelogs, etc.)
+        return value.encode('utf-8', errors='replace').decode()
 
 
 def _fix_print(value):