PR#2540: Add nomacboot option for spin-livemedia

Merges #2540
https://pagure.io/koji/pull-request/2540

Fixes: #2259
https://pagure.io/koji/issue/2259
nomacboot for livemedia builds

builder/kojid

@@ -3553,7 +3553,7 @@ class LiveMediaTask(ImageTask):
                     '--releasever', version,
                     ])
 
-        if arch == 'x86_64':
+        if arch == 'x86_64' and not opts.get('nomacboot'):
             cmd.append('--macboot')
         else:
             cmd.append('--nomacboot')

cli/koji_cli/commands.py

@@ -5701,6 +5701,8 @@ def handle_spin_livemedia(options, session, args):
                       help=_('The URL to the SCM containing any custom lorax '
                              'templates that are to be used to override the '
                              'default templates.'))
+    parser.add_option('--nomacboot', action="store_true",
+                      help=_("Pass the nomacboot option to livemedia-creator"))
     (task_options, args) = parser.parse_args(args)
 
     # Make sure the target and kickstart is specified.
@@ -6083,7 +6085,7 @@ def _build_image(options, task_opts, session, args, img_type):
         'format', 'install_tree_url', 'isoname', 'ksurl',
         'ksversion', 'release', 'repo', 'scratch', 'skip_tag',
         'specfile', 'vcpu', 'vmem', 'volid', 'optional_arches',
-        'lorax_dir', 'lorax_url',
+        'lorax_dir', 'lorax_url', 'nomacboot',
     ]
     for opt in passthru_opts:
         val = getattr(task_opts, opt, None)

tests/test_cli/test_spin_commands.py

@@ -37,6 +37,7 @@ LIVEMEDIA_OPTIONS = {
     "install_tree_url": None,
     "lorax_dir": None,
     "lorax_url": None,
+    "nomacboot": False,
     "optional_arches": None,
     "volid": None,
 }
@@ -422,6 +423,7 @@ Options:
   --lorax_url=URL       The URL to the SCM containing any custom lorax
                         templates that are to be used to override the default
                         templates.
+  --nomacboot           Pass the nomacboot option to livemedia-creator
 """ % (self.progname))