PR#841: kojid: make install timeout of imagefactory conf configurable

Merges #841
https://pagure.io/koji/pull-request/841

Fixes: #842
https://pagure.io/koji/issue/842
rfe: make imagefactory timeout configurable in kojid.conf

builder/kojid

@@ -3562,8 +3562,8 @@ class OzImageTask(BaseTaskHandler):
             #IF specific
             'imgdir': os.path.join(self.workdir, 'scratch_images'),
             'tmpdir': os.path.join(self.workdir, 'oz-tmp'),
-            'verbose' : True,
-            'timeout': 7200,
+            'verbose': True,
+            'timeout': self.options.oz_install_timeout or None,
             'output': 'log',
             'raw': False,
             'debug': True,
@@ -5709,10 +5709,10 @@ def get_options():
                 'max_retries': 120,
                 'offline_retry': True,
                 'offline_retry_interval': 120,
-                'keepalive' : True,
+                'keepalive': True,
                 'log_timestamps': False,
-                'timeout' : None,
-                'no_ssl_verify' : False,
+                'timeout': None,
+                'no_ssl_verify': False,
                 'use_fast_upload': True,
                 'use_createrepo_c': False,
                 'createrepo_skip_stat': True,
@@ -5723,8 +5723,9 @@ def get_options():
                 'yum_proxy': None,
                 'maven_repo_ignore': '*.md5 *.sha1 maven-metadata*.xml _maven.repositories '
                                      'resolver-status.properties *.lastUpdated',
-                'failed_buildroot_lifetime' : 3600 * 4,
-                'rpmbuild_timeout' : 3600 * 24,
+                'failed_buildroot_lifetime': 3600 * 4,
+                'rpmbuild_timeout': 3600 * 24,
+                'oz_install_timeout': 0,
                 'cert': None,
                 'ca': '',  # FIXME: Unused, remove in next major release
                 'serverca': None}
@@ -5732,7 +5733,7 @@ def get_options():
         for name, value in config.items('kojid'):
             if name in ['sleeptime', 'maxjobs', 'minspace', 'retry_interval',
                         'max_retries', 'offline_retry_interval', 'failed_buildroot_lifetime',
-                        'timeout', 'rpmbuild_timeout',]:
+                        'timeout', 'rpmbuild_timeout', 'oz_install_timeout']:
                 try:
                     defaults[name] = int(value)
                 except ValueError:

builder/kojid.conf

@@ -38,6 +38,11 @@
 ; Timeout for build duration (24 hours)
 ; rpmbuild_timeout=86400
 
+; Install timeout(seconds) for image build
+; Default value is 0, which means using the number in /etc/oz/oz.cfg,
+; supported since oz-0.16.0
+; oz_install_timeout=7200
+
 ; The URL for the xmlrpc server
 server=http://hub.example.com/kojihub
 

docs/source/image_build.rst

@@ -660,6 +660,11 @@ ImageFactory/Oz Preparation
     #.  python-psphere => 0.5
     #.  VMDKStream => 0.2
     #.  pykickstart
+#.  Edit ``/etc/kojid/kojid.conf``, and set an second value, eg: 7200 for
+    ``oz_install_timeout``. It's a timeout waiting guest installing. Default
+    value is 0, that means oz will use its default value. Since ``oz-0.16.0``,
+    it can be configured in ``/etc/oz/oz.cfg`` as ``install`` in ``[timeouts]``
+    section.
 #.  Edit ``/etc/oz/oz.cfg``, and set the memory value in the ``[libvirt]``
     section to at least 2048. Set ``safe_generation`` under ``[icicle]`` to yes.
 #.  Run: ``mkdir -p ~root/.psphere/templates``, and then copy the following