diff --git a/plugins/hub/sidetag_hub.py b/plugins/hub/sidetag_hub.py index bb910ed1..3cd76ce1 100644 --- a/plugins/hub/sidetag_hub.py +++ b/plugins/hub/sidetag_hub.py @@ -65,24 +65,24 @@ class SidetagOwnerTest(koji.policy.MatchTest): name = 'is_sidetag_owner' def run(self, data): - values = self.str.split()[1:] - if len(values) > 1: + fields = self.str.split()[1:] + if len(fields) > 1: raise koji.GenericError("Just one argument is allowed for this test.") - elif values: - value = values[0] - if value not in ('tag', 'fromtag', 'both'): + elif fields: + key = fields[0] + if key not in ('tag', 'fromtag', 'both'): raise koji.GenericError("Policy test is_sidetag_owner has only " - f"/tag/fromtag/both options (got {value})") - if value == 'both': - values = ['tag', 'fromtag'] + f"/tag/fromtag/both options (got {key})") + if key == 'both': + fields = ['tag', 'fromtag'] else: - values = ['tag'] + fields = ['tag'] user = policy_get_user(data) - for value in values: - if value not in data: + for field in fields: + if field not in data: return False - tag = get_tag(value) + tag = get_tag(data[field]) if not tag or not is_sidetag_owner(tag, user): return False return True