basic security checks with bandit

Fixes: https://pagure.io/koji/issue/3042
This commit is contained in:
Tomas Kopecek 2021-09-22 11:46:45 +02:00
parent 0e2ebb4e25
commit ba2e1e520b
13 changed files with 42 additions and 29 deletions

View file

@ -35,6 +35,7 @@ import json
import logging
import os
import re
import secrets
import shutil
import stat
import sys
@ -72,13 +73,6 @@ from koji.util import (
safer_move,
)
try:
# py 3.6+
import secrets
except ImportError:
import random
secrets = None
logger = logging.getLogger('koji.hub')
@ -6272,11 +6266,7 @@ def generate_token(nbytes=32):
"""
Generate random hex-string token of length 2 * nbytes
"""
if secrets:
return secrets.token_hex(nbytes=nbytes)
else:
values = ['%02x' % random.randint(0, 255) for x in range(nbytes)]
return ''.join(values)
return secrets.token_hex(nbytes=nbytes)
def get_reservation_token(build_id):