particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PR#1255: always check existence of tag in setInheritanceData

Browse source 
Merges #1255
https://pagure.io/koji/pull-request/1255

Fixes: #1252
https://pagure.io/koji/issue/1252
setInheritanceData raise Fault for non-existing tag id
This commit is contained in:
Mike McLean 2019-05-22 14:57:17 -04:00
commit bcece35a21
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
hub/kojihub.py
View file

@ -712,6 +712,8 @@ def _writeInheritanceData(tag_id, changes, clear=False):
" parent_id(%i)" % parent_id)
else:
parent_ids.add(parent_id)
# check existence of parent
get_tag(parent_id, strict=True)
# read current data and index
data = dict([[link['parent_id'], link] for link in readInheritanceData(tag_id)])
for link in changes:
@ -10175,9 +10177,8 @@ class RootExports(object):
apply the ones you submit here. If unspecified,
this defaults to False.
"""
if not isinstance(tag, six.integer_types):
#lookup tag id
tag = get_tag_id(tag, strict=True)
# verify existence of tag and/or convert name to id
tag = get_tag_id(tag, strict=True)
context.session.assertPerm('admin')
return writeInheritanceData(tag, data, clear=clear)