partial unit test with minor fix

koji/daemon.py

@@ -924,6 +924,8 @@ class TaskManager(object):
         if now - ts < delay:
             del self.skipped_tasks[task['id']]
             return True
+        # otherwise
+        return False
 
     def cleanDelayTimes(self):
         """Remove old entries from skipped_tasks"""

tests/test_builder/test_delay_times.py

@@ -0,0 +1,36 @@
+from __future__ import absolute_import
+import mock
+try:
+    import unittest2 as unittest
+except ImportError:
+    import unittest
+
+import koji.daemon
+import koji
+
+
+class TestDelayTimes(unittest.TestCase):
+
+    def setUp(self):
+        self.options = mock.MagicMock()
+        self.session = mock.MagicMock()
+        self.tm = koji.daemon.TaskManager(self.options, self.session)
+        self.time = mock.patch('time.time').start()
+
+    def tearDown(self):
+        mock.patch.stopall()
+
+    def test_check_avail_delay(self):
+        self.options.task_avail_delay = 180  # same as default
+
+        # test skipped entry less than delay
+        start = 10000
+        task = {'id': 100}
+        self.tm.skipped_tasks = {task['id']: start}
+        self.time.return_value = start + 100
+        self.assertEqual(self.tm.checkAvailDelay(task), True)
+
+        # and greater than delay
+        self.time.return_value = start + 200
+        self.tm.skipped_tasks = {task['id']: start}
+        self.assertEqual(self.tm.checkAvailDelay(task), False)