From c8ad0479ded1402498c3bceb2b37386826b6cf1e Mon Sep 17 00:00:00 2001
From: Tomas Kopecek <tkopecek@redhat.com>
Date: Mon, 13 Feb 2023 14:13:09 +0100
Subject: [PATCH] unify kwargs for gssapi_login

---
 cli/koji_cli/lib.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/cli/koji_cli/lib.py b/cli/koji_cli/lib.py
index f334bc59..15252f25 100644
--- a/cli/koji_cli/lib.py
+++ b/cli/koji_cli/lib.py
@@ -757,13 +757,12 @@ def activate_session(session, options):
         session.login()
     elif options.authtype == "kerberos" or options.authtype is None:
         try:
-            if getattr(options, 'keytab', None) and getattr(options, 'principal', None):
-                session.gssapi_login(principal=options.principal, keytab=options.keytab,
-                                     proxyuser=runas)
-            elif getattr(options, 'principal', None):
-                session.gssapi_login(principal=options.principal,proxyuser=runas)
-            else:
-                session.gssapi_login(proxyuser=runas)
+            kwargs = {'proxyuser': runas}
+            if getattr(options, 'principal', None):
+                kwargs['principal'] = options.principal
+                if getattr(options, 'keytab', None):
+                    kwargs['keytab'] = options.keytab
+            session.gssapi_login(**kwargs)
         except socket.error as e:
             warn("Could not connect to Kerberos authentication service: %s" % e.args[1])
     if not noauth and not session.logged_in: