From cb6da5074c66c65bbdb5149f72096d259f0f6357 Mon Sep 17 00:00:00 2001 From: Christopher O'Brien Date: Wed, 10 Jul 2024 14:44:05 -0400 Subject: [PATCH] change return type to list of dicts --- kojihub/kojihub.py | 6 ++++-- tests/test_hub/test_get_user_groups.py | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/kojihub/kojihub.py b/kojihub/kojihub.py index d9e2b374..b2f7b0dd 100644 --- a/kojihub/kojihub.py +++ b/kojihub/kojihub.py @@ -13419,13 +13419,15 @@ class RootExports(object): - name: User's name - krb_principal: Kerberos principal - :returns: a dict mapping member's group IDs to group names + :returns: a list of dicts, each containing the id and name of + a group :raises: GenericError if the specified user is not found """ uinfo = get_user(user, strict=True) - return get_user_groups(uinfo["id"]) + return [{'id': key, 'name': val} for key, val in + get_user_groups(uinfo["id"]).items()] def listUsers(self, userType=koji.USERTYPES['NORMAL'], prefix=None, queryOpts=None, perm=None, inherited_perm=False): diff --git a/tests/test_hub/test_get_user_groups.py b/tests/test_hub/test_get_user_groups.py index 32675616..4b23f3fd 100644 --- a/tests/test_hub/test_get_user_groups.py +++ b/tests/test_hub/test_get_user_groups.py @@ -48,5 +48,5 @@ class TestGetUserGroups(DBQueryTestCase): 'user_id': 23}) self.assertEqual(query.columns, ['group_id', 'name']) - self.assertEqual(grps, {123: 'grp_123', - 456: 'grp_456'}) + self.assertEqual(grps, [{'id': 123, 'name': 'grp_123'}, + {'id': 456, 'name': 'grp_456'}])