make query more secure

This commit is contained in:
Tomas Kopecek 2017-10-16 16:32:03 +02:00 committed by Mike McLean
parent 67149d3f91
commit cbbedd12b2
2 changed files with 10 additions and 8 deletions

View file

@ -45,8 +45,8 @@ class TestGetNotificationRecipients(unittest.TestCase):
self.assertEqual(q.columns, ('email',))
self.assertEqual(q.tables, ['build_notifications', 'users'])
self.assertEqual(q.clauses, ['users.id = build_notifications.user_id',
'users.status = 0',
'users.usertype = 0',
'users.status = %(users_status)i',
'users.usertype IN %(users_usertype)s',
'package_id IS NULL',
'tag_id IS NULL',
'success_only = FALSE'])
@ -69,8 +69,8 @@ class TestGetNotificationRecipients(unittest.TestCase):
self.assertEqual(q.columns, ('email',))
self.assertEqual(q.tables, ['build_notifications', 'users'])
self.assertEqual(q.clauses, ['users.id = build_notifications.user_id',
'users.status = 0',
'users.usertype = 0',
'users.status = %(users_status)i',
'users.usertype IN %(users_usertype)s',
'package_id = %(package_id)i OR package_id IS NULL',
'tag_id IS NULL',
'success_only = FALSE'])
@ -113,8 +113,8 @@ class TestGetNotificationRecipients(unittest.TestCase):
self.assertEqual(q.columns, ('email',))
self.assertEqual(q.tables, ['build_notifications', 'users'])
self.assertEqual(q.clauses, ['users.id = build_notifications.user_id',
'users.status = 0',
'users.usertype = 0',
'users.status = %(users_status)i',
'users.usertype IN %(users_usertype)s',
'package_id = %(package_id)i OR package_id IS NULL',
'tag_id = %(tag_id)i OR tag_id IS NULL',
'success_only = FALSE'])