From eb9ada8eb53eabfbf7ceeeadf5f40a380126fa22 Mon Sep 17 00:00:00 2001
From: Mike McLean <mikem@redhat.com>
Date: Fri, 7 Feb 2025 09:24:55 -0500
Subject: [PATCH] test config dtypes

---
 kojihub/kojixmlrpc.py         | 16 ++++++++--------
 tests/test_hub/test_config.py |  6 +++++-
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/kojihub/kojixmlrpc.py b/kojihub/kojixmlrpc.py
index 2d1e8af6..809da603 100644
--- a/kojihub/kojixmlrpc.py
+++ b/kojihub/kojixmlrpc.py
@@ -503,14 +503,14 @@ config_map = [
     ['MaxRepoTasksMaven', 'integer', 2],
     ['RepoRetries', 'integer', 3],
     ['RequestCleanTime', 'integer', 60 * 24],  # in minutes
-    ['AllowNewRepo', 'bool', True],
-    ['RepoLag', 'int', 3600],
-    ['RepoAutoLag', 'int', 7200],
-    ['RepoLagWindow', 'int', 600],
-    ['RepoQueueUser', 'str', 'kojira'],
-    ['DebuginfoTags', 'str', ''],
-    ['SourceTags', 'str', ''],
-    ['SeparateSourceTags', 'str', ''],
+    ['AllowNewRepo', 'boolean', True],
+    ['RepoLag', 'integer', 3600],
+    ['RepoAutoLag', 'integer', 7200],
+    ['RepoLagWindow', 'integer', 600],
+    ['RepoQueueUser', 'string', 'kojira'],
+    ['DebuginfoTags', 'string', ''],
+    ['SourceTags', 'string', ''],
+    ['SeparateSourceTags', 'string', ''],
 ]
 
 
diff --git a/tests/test_hub/test_config.py b/tests/test_hub/test_config.py
index 65337abc..b3a530ec 100644
--- a/tests/test_hub/test_config.py
+++ b/tests/test_hub/test_config.py
@@ -85,7 +85,6 @@ class TestHubConfig(unittest.TestCase):
         expected = 'Invalid data type badtype for BadOpt option'
         self.assertEqual(str(ex.exception), expected)
 
-
     def test_policy(self):
         config = '''
 [policy]
@@ -99,5 +98,10 @@ channel =
 
         kojixmlrpc.load_config(self.environ)
 
+    def test_map(self):
+        for row in kojixmlrpc.config_map:
+            name, dtype, default = row
+            self.assertIn(dtype, ('integer', 'boolean', 'string'))
+
 
 # the end