From ee83ceb1afd912fc4c4f7b1609db1333627828d3 Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Tue, 9 Jul 2024 16:37:58 -0400 Subject: [PATCH] check-api: only warn for external type changes --- devtools/check-api | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/devtools/check-api b/devtools/check-api index b6e4c8e1..2b442def 100755 --- a/devtools/check-api +++ b/devtools/check-api @@ -241,7 +241,11 @@ def compare_mod(mod, old, new): def compare_mod_global(mod, name, old, new): if old['type'] != new['type']: - error(f'{mod}.{name} changed type: {old["type"]} -> {new["type"]}') + if old.get('is_external'): + # not from our code, so just warn + warn(f'{mod}.{name} (external) changed type: {old["type"]} -> {new["type"]}') + else: + error(f'{mod}.{name} changed type: {old["type"]} -> {new["type"]}') # this prevents further comparison return desc = f'{mod}.{name}'