PR#2661: web: add comment explaining null start_time values
Merges #2661 https://pagure.io/koji/pull-request/2661
This commit is contained in:
commit
ffa0912bc0
1 changed files with 5 additions and 0 deletions
|
|
@ -1300,6 +1300,11 @@ def buildinfo(environ, buildID):
|
|||
if field not in values:
|
||||
values[field] = None
|
||||
|
||||
# We added the start_time field in 2015 as part of Koji's content
|
||||
# generator feature. Builds before that point have a null value for
|
||||
# start_time. Fall back to creation_ts in those cases.
|
||||
# Currently new_build() has data.setdefault('start_time', 'NOW'), so all
|
||||
# recent builds should have a value for the field.
|
||||
values['start_ts'] = build.get('start_ts') or build['creation_ts']
|
||||
# the build start time is not accurate for maven and win builds, get it from the
|
||||
# task start time instead
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue