Commit graph

599 commits

Author SHA1 Message Date
Mike McLean
f74c3b232f work around nfs glitch in ensuredir 2025-08-05 10:23:58 -04:00
Mike McLean
666d263b65 deprecate pathinfo.tmpdir 2025-05-05 16:04:35 -04:00
Mike McLean
60761e6936 revert py2 portion of mr#4214
See https://pagure.io/koji/pull-request/4214
2025-04-17 10:10:53 -04:00
Mike McLean
acbb8cc521 avoid malformed tasks for update signatures 2025-02-05 14:42:29 +01:00
Mike McLean
5973d7a13b show dups in header dump 2025-01-07 12:48:59 +01:00
Mike McLean
1019b3af35 fix store offsets when duplicate tags are present
For context, see https://pagure.io/koji/issue/4200

If an rpm has duplicate tags in a header, Koji would miscalculate the
start of that data store.
2025-01-07 12:48:59 +01:00
Yuming Zhu
b04396d333 fix removeNonprintable for PY2 2025-01-06 10:55:41 +01:00
Jana Librova
729c954f3d Fix for reading config files when contains UTF-8 chars
Fixes: https://pagure.io/koji/issue/4191
2024-11-13 20:12:18 +01:00
Tomas Kopecek
a090607a88 fix flake8 2024-06-10 09:23:45 +02:00
Mike McLean
7f98bceb6b continue to import xmlrpc_client for api compat 2024-06-10 09:02:56 +02:00
Mike McLean
68833a10a7 drop unused DBHandler class
This has been unreferenced since #507 was merged
See: https://pagure.io/koji/pull-request/507
2024-05-10 16:08:01 -04:00
Tomas Kopecek
4ad92b5cd6 Use dnf5-compatible "group install" command
* yum knows only "yum groupinstall"
 * dnf < 5 knows both
 * dnf-5 only "dnf5 group install"

From RHEL5 version of yum, @group syntax is supported, so we can
replace all groupinstall commands with "install @group".

Related: https://pagure.io/koji/issue/3971
2024-03-05 13:17:35 +01:00
Mike McLean
cfd6d3064f show hub version in koji hello 2024-02-29 15:40:03 +01:00
Mike McLean
8e6737a116 avoid clearing cached hub version 2024-02-29 15:40:03 +01:00
Mike McLean
62f279ad43 move version fetching to hub_version_str property 2024-02-29 15:40:03 +01:00
Tomas Kopecek
7a9b0561eb Don't try to resolve server version for old hubs
Related: https://pagure.io/koji/issue/3890
2024-02-29 15:40:03 +01:00
Tomas Kopecek
77b7e3a0c9 Fix bandit "nosec" comments
Related: https://pagure.io/koji/issue/4004
2024-02-06 11:09:16 +01:00
Yu Ming Zhu
f41b8c70a7 Bandit [B411]: use defusedxml to prevent remote XML attacks
- putting xmlrpc stuff into koji.xmlrpcplus
- adding koji.xmlrpcplus.xmlrpc_server to refer
- replacing refs of original xmlrpc.client.dumps to enhanced
  koji.xmlrpcplus.dumps

fixes: #3964
2024-02-02 09:08:18 +01:00
Yu Ming Zhu
deaa6a01e8 gen_draft_release: clearer argument naming not to mask builtin id function 2024-01-05 10:00:51 +00:00
Yu Ming Zhu
34c6712fde simpler gen_draft_release and parse_target_release 2024-01-05 10:00:47 +00:00
Mike McLean
ea86bd90b7 change draft suffix format to be url friendly 2024-01-05 10:00:42 +00:00
Mike McLean
ecdeba8c72 raise http errors in downloadFile 2024-01-05 10:00:42 +00:00
Yu Ming Zhu
f29e5e143e parse target_release from draft release instead of extra.draft.target_release 2024-01-05 10:00:38 +00:00
Yuming Zhu
241daabecd remove unused methods in PathInfo 2024-01-05 10:00:33 +00:00
Yu Ming Zhu
77a06c98b3 draft filter opt: use bool/None instead of bit flag 2024-01-05 10:00:33 +00:00
Yuming Zhu
87409499a3 draft builds 2024-01-05 10:00:29 +00:00
Mike McLean
629a0f2628 fix arg passing in exclusiveSession
Fixes https://pagure.io/koji/issue/3947
2023-11-27 20:51:48 -05:00
Tomas Kopecek
9b48b9c01d Switch to filewwatcher logger
Don't use koji's logrotate and let system handle it.

Related: https://pagure.io/koji/issue/3392
2023-09-04 09:20:16 +02:00
Tomas Kopecek
c0bc73fdc0 disable use_bootstrap_image if not requested
Related: https://pagure.io/koji/issue/3872
2023-08-28 12:56:49 +02:00
Ken Dreyer
6b842439b0 explain _ord() method
This method is a historical oddity that we needed to deal with pieces of
RPM headers (strings) on Python 2. Since ord() no longer exists on
Python 3, it's difficult for new developers to understand what this code
is.  Add comments so it's easier to read.
2023-05-30 14:44:56 -04:00
Jana Cupova
0c00dceb07 Remove get_sequence_value in 1.34
Fixes: https://pagure.io/koji/issue/3635
2023-05-24 09:38:05 +02:00
Jana Cupova
8f9a4d438e Remove koji.AUTHTYPE_* in 1.34
Fixes: https://pagure.io/koji/issue/3441
2023-05-24 09:37:22 +02:00
Mike McLean
cf94d9ad24 avoid noisy chained tracebacks when converting Faults 2023-05-11 15:06:41 +02:00
Tomas Kopecek
fddb5de41f Fix typo 2023-05-11 15:02:23 +02:00
Mike McLean
106ccbcde5 single opt for get, plus simple unit test 2023-03-23 13:20:06 +01:00
Mike McLean
898af45e4f flake8 fix 2023-03-23 13:20:06 +01:00
Mike McLean
1d117742fa use surrogateescape to decode in RawHeader 2023-03-23 13:20:06 +01:00
Mike McLean
46b15774bd decode option in RawHeader, handle integer counts 2023-03-23 13:20:06 +01:00
Tomas Kopecek
d6d5eceefd flake8 fix 2023-03-23 13:20:06 +01:00
Mike McLean
ed22da06c8 RawHeader doesn't actually need rpmlib 2023-03-23 13:20:06 +01:00
Mike McLean
d8f7564c45 redundant constant 2023-03-23 13:20:06 +01:00
Mike McLean
d094ace4c4 autodetect signature headers in RawHeader.dump() 2023-03-23 13:20:06 +01:00
Mike McLean
81058ba0cd RawHeader.dump improvements 2023-03-23 13:20:06 +01:00
Mike McLean
3f4c97f372 Fix sig header field names in RawHeader.dump() 2023-03-23 13:20:06 +01:00
Mike McLean
c3cd98d152 only pad header lengths for signature headers
Based on a workaround by puiterwijk
https://github.com/fedora-iot/rpm-head-signing/pull/61/files
2023-03-14 11:08:16 +01:00
Mike McLean
8afea8083b attempt to decode strings in dump 2023-03-07 12:50:10 +01:00
Mike McLean
d723e126bf also support get for unicode string arrays 2023-03-07 12:50:10 +01:00
Tomas Kopecek
a0ffd9f434 RawHeader.get can return also string lists
Related: https://pagure.io/koji/issue/3713
2023-03-07 12:50:10 +01:00
Tomas Kopecek
b0e91e378c Move db/auth to kojihub module
Related: https://pagure.io/koji/issue/3666
2023-03-01 11:46:24 +01:00
Jana Cupova
59f5a4e19b Fix unlogging session
Fixes: https://pagure.io/koji/issue/3394
2023-02-07 13:13:17 +01:00