With the current code, trying to SSL-login with a bad certificate will
just make it look like the client code is hanging.
That's because it tries and tries again, silently, until it reaches it's
maximum retry limit.
But in the case of an SSL error, such as an expired client cert, there's
really no point in retrying.
Although this is often a surprising behaviour, the Python documentation
is quite clear on this:
If a component is an absolute path, all previous components are
thrown away and joining continues from the absolute path component.
https://docs.python.org/2/library/os.path.html#os.path.join
That means we need to ensure that we don't end up in this case.
Citing from reindent docs:
Change Python (.py) files to use 4-space indents and no hard tab
characters. Also trim excess spaces and tabs from ends of lines, and
remove empty lines at the end of files. Also ensure the last line
ends with a newline.
Citing from PEP 8:
Use 4 spaces per indentation level.
Python 2 code indented with a mixture of tabs and spaces should be
converted to using spaces exclusively.
Don't write string literals that rely on significant trailing
whitespace. Such trailing whitespace is visually indistinguishable
and some editors (or more recently, reindent.py) will trim them.
Also PyLint recommends not to have trailing whitespace on any line.
The code previously would look for a file called extra-footer.html that a koji
admin could override to put some nice extra footer on their koji-web page.
If that file existed, koji-web would read it in verbatim and write it to the
bottom of each served page.
This change enhances that behavior and treats the extra-footer.html file as a
Cheetah template. This way, a koji admin could specify some conditional logic
in the extra-footer file to display this or that thing depending on the dynamic
contents of the page being served.
Note that this is backwards compatible. Static html extra-footer files
already out there in the wild will be interpreted as Cheetah templates and
should be included seamlessly.
This will allow us in Fedora to style system account names differently. For
instance, we can markup the name 'koschei' (our continuous integration bot).
The mergeScratch() method allows importing rpms built by a scratch build into an existing build, if that build
did not produce rpms matching the arch of the scratch build. This is useful for bootstrapping a new arch into
existing builds, and avoiding a mass-rebuild to add arch support.
