Koji now uses ssl via python-requests
- use_old_ssl option is removed
- koji.ssl library removed
- compatrequests dropped
Related: https://pagure.io/koji/issue/467
Sometimes the recipient email may no longer be valid due to many
reasons. Handle the failure to send email gracefully.
Signed-off-by: Dennis Gilmore <dennis@ausil.us>
This reverts commit 02128ee577.
The second column in cfgmap is an alias and "True" is not a valid alias.
It was mistaken in the reverted commit as a default value, which it is
not. Reverting this commit should fix the following traceback that
koji-gc in Fedora currenty raises:
Traceback (most recent call last):
File "/usr/sbin/koji-gc", line 901, in <module>
options, args = get_options()
File "/usr/sbin/koji-gc", line 159, in get_options
if config.has_option(*alias):
TypeError: has_option() argument after * must be a sequence, not bool
The client CA is only needed to for authentication on the server side,
not for authentication on the client side. Therefore remove it from all
client login code.
Citing from reindent docs:
Change Python (.py) files to use 4-space indents and no hard tab
characters. Also trim excess spaces and tabs from ends of lines, and
remove empty lines at the end of files. Also ensure the last line
ends with a newline.
Citing from PEP 8:
Use 4 spaces per indentation level.
Python 2 code indented with a mixture of tabs and spaces should be
converted to using spaces exclusively.
Don't write string literals that rely on significant trailing
whitespace. Such trailing whitespace is visually indistinguishable
and some editors (or more recently, reindent.py) will trim them.
Also PyLint recommends not to have trailing whitespace on any line.
The current descriptions for koji-gc's SSL options appear to be the
result of copy & paste. Update the description for each individual SSL
option to match its functionality.
