particle-os/particle-os-modules
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Get rid of SCHEMA_ID dependency!

Browse source 
gschema.xml can be copied without knowing the original name.
This commit is contained in:
fiftydinar 2024-04-08 22:16:46 +02:00
parent a71bd6cc55
commit 5ab351bfda
2 changed files with 1 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
modules/gnome-extensions/README.md
View file

@ -25,9 +25,3 @@ or by simply downloading the zip file from https://extensions.gnome.org & than l
You must assure that version of the extension is compatible with current Gnome version that your image is using.
You can easily see this information when downloading extension from https://extensions.gnome.org
# Known Issues
Some extensions may lack information in metadata.json, like lack of `uuid`, `settings-schema` or `shell-version` key,
which is necessary for the module to automatically install extension. Developer can easily fix this issue, so it's advised to inform him if this issue occured.
As a safe-check, build will fail if any of those 3 keys are not present in extensions metadata.json file.

8
modules/gnome-extensions/gnome-extensions.sh
View file

@ -27,7 +27,6 @@ if [[ ${#GETTEXT_DOMAIN[@]} -gt 0 ]]; then
echo "Reading necessary info from metadata.json"
EXTENSION_NAME=$(yq '.name' < "${TMP_DIR}/metadata.json")
UUID=$(yq '.uuid' < "${TMP_DIR}/metadata.json")
SCHEMA_ID=$(yq '.settings-schema' < "${TMP_DIR}/metadata.json")
EXT_GNOME_VER=$(yq '.shell-version[]' < "${TMP_DIR}/metadata.json")
# If extension does not have the important key in metadata.json,
# inform the user & fail the build
@ -36,11 +35,6 @@ if [[ ${#GETTEXT_DOMAIN[@]} -gt 0 ]]; then
echo "You may inform the extension developer about this error, as he can fix it"
exit 1
fi
if [[ "${SCHEMA_ID}" == "null" ]]; then
echo "ERROR: Extension ${EXTENSION_NAME} doesn't have 'settings-schema' key inside metadata.json"
echo "You may inform the extension developer about this error, as he can fix it"
exit 1
fi
if [[ "${EXT_GNOME_VER}" == "null" ]]; then
echo "ERROR: Extension ${EXTENSION_NAME} doesn't have 'shell-version' key inside metadata.json"
echo "You may inform the extension developer about this error, as he can fix it"
@ -61,7 +55,7 @@ if [[ ${#GETTEXT_DOMAIN[@]} -gt 0 ]]; then
# Install schema
echo "Installing schema extension file"
install -d -m 0755 "/usr/share/glib-2.0/schemas/"
install -D -p -m 0644 "${TMP_DIR}/schemas/${SCHEMA_ID}.gschema.xml" "/usr/share/glib-2.0/schemas/${SCHEMA_ID}.gschema.xml"
install -D -p -m 0644 "${TMP_DIR}/schemas/"*.gschema.xml "/usr/share/glib-2.0/schemas/"
# Install languages
echo "Installing language extension files"
install -d -m 0755 "/usr/share/locale/"