robojerk/codeql-action

Don't crash if we are unable to get a response from the feature-flag endpoint.

Browse source
This commit is contained in:
Cornelius Riemenschneider 2022-07-18 10:14:40 +00:00 • committed by GitHub
parent d8c9c723a5
commit 01fa64cb90
3 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/feature-flags.ts
View file

@ -31,14 +31,21 @@ export class GitHubFeatureFlags implements FeatureFlags {
) {}
async getValue(flag: FeatureFlag): Promise<boolean> {
const response = (await this.getApiResponse())[flag];
const response = await this.getApiResponse();
if (response === undefined) {
this.logger.debug(
`No feature flags API response for ${flag}, considering it disabled.`
);
return false;
}
const flag_value = response[flag];
if (flag_value === undefined) {
this.logger.debug(
`Feature flag '${flag}' undefined in API response, considering it disabled.`
);
return false;
}
return response;
return flag_value;
}
private async getApiResponse(): Promise<FeatureFlagsApiResponse> {