robojerk/codeql-action

Add a comment to explain why we show the upgrade message on GHES 3.4

Browse source
This commit is contained in:
Henry Mercer 2022-04-28 14:15:04 +01:00
parent 35ef6a2db3
commit 02083c307e
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/util.js generated
View file

@ -608,6 +608,10 @@ async function checkActionVersion(version) {
if (!semver.satisfies(version, ">=2")) {
const githubVersion = await api.getGitHubVersionActionsOnly();
// Only log a warning for versions of GHES that are compatible with CodeQL Action version 2.
//
// GHES 3.4 shipped without the v2 tag, but it also shipped without this warning message code.
// Therefore users who are seeing this warning message code have pulled in a new version of the
// Action, and with it the v2 tag.
if (githubVersion.type === GitHubVariant.DOTCOM ||
githubVersion.type === GitHubVariant.GHAE ||
(githubVersion.type === GitHubVariant.GHES &&

2
lib/util.js.map
View file

File diff suppressed because one or more lines are too long

4
src/util.ts
View file

@ -721,6 +721,10 @@ export async function checkActionVersion(version: string) {
if (!semver.satisfies(version, ">=2")) {
const githubVersion = await api.getGitHubVersionActionsOnly();
// Only log a warning for versions of GHES that are compatible with CodeQL Action version 2.
//
// GHES 3.4 shipped without the v2 tag, but it also shipped without this warning message code.
// Therefore users who are seeing this warning message code have pulled in a new version of the
// Action, and with it the v2 tag.
if (
githubVersion.type === GitHubVariant.DOTCOM ||
githubVersion.type === GitHubVariant.GHAE ||