address comments

This commit is contained in:
Robert 2020-07-21 12:19:37 +01:00
parent 29cf06569d
commit 0446cb0aff
6 changed files with 14 additions and 10 deletions

View file

@ -206,7 +206,7 @@ test("default queries are used", async t => {
process.env['GITHUB_WORKSPACE'] = tmpDir;
// Check that the default behaviour is to add the default queries.
// In this case if a config file is specified by does not include
// In this case if a config file is specified but does not include
// the disable-default-queries field.
// We determine this by whether CodeQL.resolveQueries is called
// with the correct arguments.
@ -225,7 +225,9 @@ test("default queries are used", async t => {
},
});
// Just create a generic config object with non-default values for all fields
// The important point of this config is that is doesn't specify
// the disable-default-queries field.
// Any other details are hopefully irrelevant for this tetst.
const inputFileContents = `
paths:
- foo`;

View file

@ -51,10 +51,10 @@ export function setupTests(test: TestInterface<any>) {
process.stderr.write = wrapOutput(t.context) as any;
// Many tests modify environment variables. Take a copy now so that
// We reset them after the test to keep tests independent of each other.
// we reset them after the test to keep tests independent of each other.
// process.env only has strings fields, so a shallow copy is fine.
t.context.env = {};
Object.assign(process.env, t.context.env);
Object.assign(t.context.env, process.env);
});
typedTest.afterEach.always(t => {