robojerk/codeql-action

Merge pull request #80 from github/symlinks_test

Browse source 
Make the temporary directory in tests a symlink
This commit is contained in:
Robert 2020-06-24 10:23:06 +01:00 • committed by GitHub
commit 04adf2bf60
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/util.js generated
View file

@ -349,7 +349,11 @@ exports.getToolNames = getToolNames;
// Mostly intended for use within tests. // Mostly intended for use within tests.
async function withTmpDir(body) { async function withTmpDir(body) {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codeql-action-')); const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codeql-action-'));
const result = await body(tmpDir); const realSubdir = path.join(tmpDir, 'real');
fs.mkdirSync(realSubdir);
const symlinkSubdir = path.join(tmpDir, 'symlink');
fs.symlinkSync(realSubdir, symlinkSubdir, 'dir');
const result = await body(symlinkSubdir);
fs.rmdirSync(tmpDir, { recursive: true }); fs.rmdirSync(tmpDir, { recursive: true });
return result; return result;
} }

2
lib/util.js.map
View file

File diff suppressed because one or more lines are too long

6
src/util.ts
View file

@ -389,7 +389,11 @@ export function getToolNames(sarifContents: string): string[] {
// Mostly intended for use within tests. // Mostly intended for use within tests.
export async function withTmpDir<T>(body: (tmpDir: string) => Promise<T>): Promise<T> { export async function withTmpDir<T>(body: (tmpDir: string) => Promise<T>): Promise<T> {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codeql-action-')); const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codeql-action-'));
const result = await body(tmpDir); const realSubdir = path.join(tmpDir, 'real');
fs.mkdirSync(realSubdir);
const symlinkSubdir = path.join(tmpDir, 'symlink');
fs.symlinkSync(realSubdir, symlinkSubdir, 'dir');
const result = await body(symlinkSubdir);
fs.rmdirSync(tmpDir, { recursive: true }); fs.rmdirSync(tmpDir, { recursive: true });
return result; return result;
} }