robojerk/codeql-action

Only check the steps of the job currently being run

Browse source
This commit is contained in:
Simon Engledew 2021-01-04 12:00:15 +00:00
parent e89a24b8cb
commit 1511db33b3
No known key found for this signature in database
GPG key ID: 84302E7B02FE8BCE
6 changed files with 37 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/actions-util.ts
View file

@ -211,10 +211,15 @@ export const WorkflowErrors = toCodedErrors({
export function validateWorkflow(doc: Workflow): CodedError[] {
const errors: CodedError[] = [];
// .jobs[key].steps[].run
outer: for (const job of Object.values(doc?.jobs || {})) {
if (Array.isArray(job?.steps)) {
for (const step of job?.steps) {
const jobName = process.env.GITHUB_JOB;
if (jobName) {
const job = doc?.jobs?.[jobName];
const steps = job?.steps;
if (Array.isArray(steps)) {
for (const step of steps) {
// this was advice that we used to give in the README
// we actually want to run the analysis on the merge commit
// to produce results that are more inline with expectations
@ -222,7 +227,7 @@ export function validateWorkflow(doc: Workflow): CodedError[] {
// and avoid some race conditions
if (step?.run === "git checkout HEAD^2") {
errors.push(WorkflowErrors.CheckoutWrongHead);
break outer;
break;
}
}
}