Enable no console rule

src/database-upload.ts

@@ -88,7 +88,6 @@ export async function uploadDatabases(
         bundledDbReadStream.close();
       }
     } catch (e) {
-      console.log(e);
       // Log a warning but don't fail the workflow
       logger.warning(`Failed to upload database for ${language}: ${e}`);
     }

src/logging.ts

@@ -18,9 +18,13 @@ export function getActionsLogger(): Logger {
 
 export function getRunnerLogger(debugMode: boolean): Logger {
   return {
+    // eslint-disable-next-line no-console
     debug: debugMode ? console.debug : () => undefined,
+    // eslint-disable-next-line no-console
     info: console.info,
+    // eslint-disable-next-line no-console
     warning: console.warn,
+    // eslint-disable-next-line no-console
     error: console.error,
     isDebug: () => debugMode,
     startGroup: () => undefined,

src/status-report.ts

@@ -25,6 +25,7 @@ import {
   DiskUsage,
   assertNever,
   BuildMode,
+  wrapError,
 } from "./util";
 
 export enum ActionName {
@@ -402,7 +403,6 @@ export async function sendStatusReport<S extends StatusReportBase>(
       },
     );
   } catch (e) {
-    console.log(e);
     if (isHTTPError(e)) {
       switch (e.status) {
         case 403:
@@ -439,7 +439,9 @@ export async function sendStatusReport<S extends StatusReportBase>(
     // something else has gone wrong and the request/response will be logged by octokit
     // it's possible this is a transient error and we should continue scanning
     core.warning(
-      "An unexpected error occurred when sending code scanning status report.",
+      `An unexpected error occurred when sending code scanning status report: ${
+        wrapError(e).message
+      }`,
     );
   }
 }

src/testing-utils.ts

@@ -151,18 +151,22 @@ export function getRecordingLogger(messages: LoggedMessage[]): Logger {
   return {
     debug: (message: string) => {
       messages.push({ type: "debug", message });
+      // eslint-disable-next-line no-console
       console.debug(message);
     },
     info: (message: string) => {
       messages.push({ type: "info", message });
+      // eslint-disable-next-line no-console
       console.info(message);
     },
     warning: (message: string | Error) => {
       messages.push({ type: "warning", message });
+      // eslint-disable-next-line no-console
       console.warn(message);
     },
     error: (message: string | Error) => {
       messages.push({ type: "error", message });
+      // eslint-disable-next-line no-console
       console.error(message);
     },
     isDebug: () => true,

src/upload-sarif-action.ts

@@ -98,7 +98,6 @@ async function run() {
         : wrapError(unwrappedError);
     const message = error.message;
     core.setFailed(message);
-    console.log(error);
 
     const errorStatusReportBase = await createStatusReportBase(
       ActionName.UploadSarif,