Merge pull request #1939 from github/aeisenberg/enable-kotlin-tests

Re-enable kotlin tests

pr-checks/checks/unset-environment.yml

@@ -17,9 +17,7 @@ steps:
       go-version: '>=1.21.0'
   - name: Build code
     shell: bash
-    # Disable Kotlin analysis while it's incompatible with Kotlin 1.8, until we find a
-    # workaround for our PR checks.
-    run: env -i CODEQL_EXTRACTOR_JAVA_AGENT_DISABLE_KOTLIN=true PATH="$PATH" HOME="$HOME" ./build.sh
+    run: env -i PATH="$PATH" HOME="$HOME" ./build.sh
   - uses: ./../action/analyze
     id: analysis
     with:

pr-checks/sync.py

@@ -72,7 +72,7 @@ for file in (this_dir / 'checks').glob('*.yml'):
                     'os': "macos-12",
                     'version': version
                 })
-            else:     
+            else:
                 matrix.append({
                     'os': runnerImage,
                     'version': version
@@ -108,7 +108,10 @@ for file in (this_dir / 'checks').glob('*.yml'):
             'uses': './.github/actions/prepare-test',
             'with': {
                 'version': '${{ matrix.version }}',
-                'use-all-platform-bundle': useAllPlatformBundle
+                'use-all-platform-bundle': useAllPlatformBundle,
+                # If the action is being run from a container, then do not setup kotlin.
+                # This is because the kotlin binaries cannot be downloaded from the container.
+                'setup-kotlin': str(not 'container' in checkSpecification).lower(),
             }
         },
     ]
@@ -149,10 +152,7 @@ for file in (this_dir / 'checks').glob('*.yml'):
             'name': f"PR Check - {checkSpecification['name']}",
             'env': {
                 'GITHUB_TOKEN': '${{ secrets.GITHUB_TOKEN }}',
-                'GO111MODULE': 'auto',
-                # Disable Kotlin analysis while it's incompatible with Kotlin 1.8, until we find a
-                # workaround for our PR checks.
-                'CODEQL_EXTRACTOR_JAVA_AGENT_DISABLE_KOTLIN': 'true',
+                'GO111MODULE': 'auto'
             },
             'on': {
                 'push': {