Update comment

This commit is contained in:
Koen Vlaswinkel 2024-05-02 14:01:44 +02:00
parent 725ed4139d
commit 3a471a06fa
3 changed files with 5 additions and 3 deletions

3
lib/upload-lib.js generated
View file

@ -120,7 +120,8 @@ async function shouldShowCombineSarifFilesDeprecationWarning(sarifObjects, featu
semver.lt(githubVersion.version, "3.14.0")) { semver.lt(githubVersion.version, "3.14.0")) {
return false; return false;
} }
// Only give a deprecation warning when not all runs are unique // Only give a deprecation warning when not all runs are unique and
// we haven't already shown the warning.
return (!areAllRunsUnique(sarifObjects) && return (!areAllRunsUnique(sarifObjects) &&
!process.env.CODEQL_MERGE_SARIF_DEPRECATION_WARNING); !process.env.CODEQL_MERGE_SARIF_DEPRECATION_WARNING);
} }

File diff suppressed because one or more lines are too long

View file

@ -140,7 +140,8 @@ export async function shouldShowCombineSarifFilesDeprecationWarning(
return false; return false;
} }
// Only give a deprecation warning when not all runs are unique // Only give a deprecation warning when not all runs are unique and
// we haven't already shown the warning.
return ( return (
!areAllRunsUnique(sarifObjects) && !areAllRunsUnique(sarifObjects) &&
!process.env.CODEQL_MERGE_SARIF_DEPRECATION_WARNING !process.env.CODEQL_MERGE_SARIF_DEPRECATION_WARNING