Apply suggestions from code review

Co-authored-by: Henry Mercer <henry.mercer@me.com>
This commit is contained in:
Andrew Eisenberg 2023-02-09 11:19:27 -08:00
parent e2f72f11e4
commit 3c81243bb1
15 changed files with 130 additions and 91 deletions

View file

@ -2283,7 +2283,7 @@ test("downloadPacks-no-registries", async (t) => {
},
sampleApiDetails,
undefined, // registriesAuthTokens
tmpDir, // qlconfig file path
tmpDir,
logger
);
@ -2481,12 +2481,6 @@ test("no generateRegistries when CLI is too old", async (t) => {
packages: ["codeql/*", "dsp-testing/*"],
token: "not-a-token",
},
{
// with slash
url: "https://containers.GHEHOSTNAME1/v2/",
packages: "semmle/*",
token: "still-not-a-token",
},
]);
const codeQL = setCodeQL({
// Accepted CLI versions are 2.10.4 or higher
@ -2504,9 +2498,6 @@ test("no generateRegistries when CLI is too old", async (t) => {
undefined,
"'registries' input is not supported on CodeQL versions less than 2.10.4."
);
// t.is(registriesAuthTokens, undefined);
// t.is(qlconfigFile, undefined);
});
});
test("no generateRegistries when registries is undefined", async (t) => {