robojerk/codeql-action

Address more comments from PR

Browse source
This commit is contained in:
Andrew Eisenberg 2023-08-29 13:20:55 -07:00
parent e603106d1a
commit 469786860d
6 changed files with 20 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/actions-util.test.ts
View file

@ -282,23 +282,23 @@ test("determineMergeBaseCommitOid non-pullrequest", async (t) => {
});
test("determineMergeBaseCommitOid no error", async (t) => {
const stub = sinon.stub(core, "info");
const infoStub = sinon.stub(core, "info");
process.env["GITHUB_EVENT_NAME"] = "pull_request";
process.env["GITHUB_SHA"] = "100912429fab4cb230e66ffb11e738ac5194e73a";
await actionsUtil.determineMergeBaseCommitOid(path.join(__dirname, "../.."));
t.deepEqual(1, stub.callCount);
t.deepEqual(1, infoStub.callCount);
t.assert(
stub.firstCall.args[0].startsWith(
infoStub.firstCall.args[0].startsWith(
"The checkout path provided to the action does not appear to be a git repository.",
),
);
stub.restore();
infoStub.restore();
});
test("determineMergeBaseCommitOid other error", async (t) => {
const stub = sinon.stub(core, "info");
const infoStub = sinon.stub(core, "info");
process.env["GITHUB_EVENT_NAME"] = "pull_request";
process.env["GITHUB_SHA"] = "100912429fab4cb230e66ffb11e738ac5194e73a";
@ -306,12 +306,12 @@ test("determineMergeBaseCommitOid other error", async (t) => {
path.join(__dirname, "../../i-dont-exist"),
);
t.deepEqual(result, undefined);
t.deepEqual(1, stub.callCount);
t.deepEqual(1, infoStub.callCount);
t.assert(
stub.firstCall.args[0].startsWith(
infoStub.firstCall.args[0].startsWith(
"Failed to call git to determine merge base.",
),
);
stub.restore();
infoStub.restore();
});

3
src/actions-util.ts
View file

@ -91,8 +91,7 @@ export const getCommitOid = async function (
);
} else {
core.info(
`Could not determine current commit SHA using git. Continuing with data from user input or environment. ` +
`Failed to call git to determine merge base. Continuing with data from environment: ${stderr}`,
`Could not determine current commit SHA using git. Continuing with data from user input or environment. ${stderr}`,
);
}