robojerk/codeql-action

Ignore non-string values in populateRunAutomationDetails

Browse source
This commit is contained in:
David Verdeguer 2021-04-20 12:53:16 +02:00
parent 8bd2b3516b
commit 496bf0ec11
6 changed files with 34 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/upload-lib.test.js generated
View file

@ -96,7 +96,12 @@ ava_1.default("populateRunAutomationDetails", (t) => {
'{"runs":[{"automationDetails":{"id":".github/workflows/codeql-analysis.yml:analyze/"}}]}';
modifiedSarif = uploadLib.populateRunAutomationDetails(sarif, analysisKey, "{}");
t.deepEqual(modifiedSarif, expectedSarif);
// check that an empty environment produces the right results
// check non string environment values
expectedSarif =
'{"runs":[{"automationDetails":{"id":".github/workflows/codeql-analysis.yml:analyze/number:/object:/"}}]}';
modifiedSarif = uploadLib.populateRunAutomationDetails(sarif, analysisKey, '{"number": 1, "object": {"language": "javascript"}}');
t.deepEqual(modifiedSarif, expectedSarif);
// check that the automation details doesn't get overwritten
sarif = '{"runs":[{"automationDetails":{"id":"my_id"}}]}';
expectedSarif = '{"runs":[{"automationDetails":{"id":"my_id"}}]}';
modifiedSarif = uploadLib.populateRunAutomationDetails(sarif, analysisKey, '{"os": "linux", "language": "javascript"}');