Address additional review comments

This commit is contained in:
Angela P Wen 2022-08-11 13:58:01 +02:00
parent d909f714fb
commit 4e121c0ef5
4 changed files with 10 additions and 6 deletions

5
lib/actions-util.js generated
View file

@ -692,8 +692,9 @@ async function printDebugLogs(config) {
} }
for (const entry of entries) { for (const entry of entries) {
if (entry.isFile()) { if (entry.isFile()) {
core.startGroup(`CodeQL Debug Logs - ${language} - ${entry.name}`); const absolutePath = path.resolve(dir, entry.name);
process.stdout.write(fs.readFileSync(path.resolve(dir, entry.name))); core.startGroup(`CodeQL Debug Logs - ${language} - ${entry.name} from file at path ${absolutePath}`);
process.stdout.write(fs.readFileSync(absolutePath));
core.endGroup(); core.endGroup();
} }
else if (entry.isDirectory()) { else if (entry.isDirectory()) {

File diff suppressed because one or more lines are too long

2
lib/util.js generated
View file

@ -652,7 +652,7 @@ function doesDirectoryExist(dirPath) {
} }
exports.doesDirectoryExist = doesDirectoryExist; exports.doesDirectoryExist = doesDirectoryExist;
/** /**
* Returns a list of files in a given directory. * Returns a recursive list of files in a given directory.
*/ */
function listFolder(dir) { function listFolder(dir) {
if (!doesDirectoryExist(dir)) { if (!doesDirectoryExist(dir)) {

View file

@ -891,8 +891,11 @@ export async function printDebugLogs(config: Config) {
} }
for (const entry of entries) { for (const entry of entries) {
if (entry.isFile()) { if (entry.isFile()) {
core.startGroup(`CodeQL Debug Logs - ${language} - ${entry.name}`); const absolutePath = path.resolve(dir, entry.name);
process.stdout.write(fs.readFileSync(path.resolve(dir, entry.name))); core.startGroup(
`CodeQL Debug Logs - ${language} - ${entry.name} from file at path ${absolutePath}`
);
process.stdout.write(fs.readFileSync(absolutePath));
core.endGroup(); core.endGroup();
} else if (entry.isDirectory()) { } else if (entry.isDirectory()) {
walkLogFiles(path.resolve(dir, entry.name)); walkLogFiles(path.resolve(dir, entry.name));