Address comments from review

This commit is contained in:
Andrew Eisenberg 2022-10-06 13:14:06 -07:00
parent 6de05e4b24
commit 5915e70486
6 changed files with 7 additions and 9 deletions

View file

@ -56,9 +56,8 @@ for (const variant of ALL_FEATURE_FLAGS_DISABLED_VARIANTS) {
);
for (const flag of Object.values(Feature)) {
t.assert(
(await featureFlags.getValue(flag, includeCodeQlIfRequired(flag))) ===
false
t.false(
await featureFlags.getValue(flag, includeCodeQlIfRequired(flag))
);
}

View file

@ -75,7 +75,7 @@ export class GitHubFeatureFlags implements FeatureFlags {
async getValue(flag: Feature, codeql?: CodeQL): Promise<boolean> {
if (!codeql && featureConfig[flag].minimumVersion) {
throw new Error(
`A minimum version is specified for feature flag ${flag}, but no instance of CodeQL was provided.`
`Internal error: A minimum version is specified for feature flag ${flag}, but no instance of CodeQL was provided.`
);
}