robojerk/codeql-action

Explicitly pass repository to feature flags constructor

Browse source 
As suggested in review: The `GITHUB_REPOSITORY` environment variable is
only available on Actions. Passing it in explicitly avoids potentially
crashing if this code is called from the runner.
This commit is contained in:
Henry Mercer 2021-12-15 17:03:43 +00:00
parent 621e0794ac
commit 5e87034b3b
9 changed files with 31 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/feature-flags.js generated
View file

@ -21,12 +21,12 @@ var __importStar = (this && this.__importStar) || function (mod) {
Object.defineProperty(exports, "__esModule", { value: true });
exports.createFeatureFlags = exports.GitHubFeatureFlags = void 0;
const api_client_1 = require("./api-client");
const repository_1 = require("./repository");
const util = __importStar(require("./util"));
class GitHubFeatureFlags {
constructor(gitHubVersion, apiDetails, logger) {
constructor(gitHubVersion, apiDetails, repositoryNwo, logger) {
this.gitHubVersion = gitHubVersion;
this.apiDetails = apiDetails;
this.repositoryNwo = repositoryNwo;
this.logger = logger;
}
getDatabaseUploadsEnabled() {
@ -56,11 +56,10 @@ class GitHubFeatureFlags {
return {};
}
const client = (0, api_client_1.getApiClient)(this.apiDetails);
const repositoryNwo = (0, repository_1.parseRepositoryNwo)(util.getRequiredEnvParam("GITHUB_REPOSITORY"));
try {
const response = await client.request("GET /repos/:owner/:repo/code-scanning/codeql-action/features", {
owner: repositoryNwo.owner,
repo: repositoryNwo.repo,
owner: this.repositoryNwo.owner,
repo: this.repositoryNwo.repo,
});
return response.data;
}