robojerk/codeql-action

getPullRequestEditedDiffRanges: check the number of changed files

Browse source
This commit is contained in:
Chuan-kai Lin 2025-01-13 08:03:34 -08:00
parent 68b1b4e9eb
commit 63d1f4f8a2
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/analyze.ts
View file

@ -298,6 +298,17 @@ async function getPullRequestEditedDiffRanges(
if (fileDiffs === undefined) {
return undefined;
}
if (fileDiffs.length >= 300) {
// The "compare two commits" API returns a maximum of 300 changed files. If
// we see that many changed files, it is possible that there could be more,
// with the rest being truncated. In this case, we should not attempt to
// compute the diff ranges, as the result would be incomplete.
logger.warning(
`Cannot retrieve the full diff because there are too many ` +
`(${fileDiffs.length}) changed files in the pull request.`,
);
return undefined;
}
const results: DiffThunkRange[] = [];
for (const filediff of fileDiffs) {
const diffRanges = getDiffRanges(filediff, logger);