Remove unused status report fields

lib/analyze.js

@@ -136,12 +136,12 @@ async function runQueries(sarifFolder, memoryFlag, addSnippetsFlag, threadsFlag,
             // call to run all the queries for each language and
             // another to interpret the results.
             logger.startGroup(`Running queries for ${language}`);
-            const startTimeBuiltIn = new Date().getTime();
+            const startTimeRunQueries = new Date().getTime();
             await runQueryGroup(language, "all", undefined, undefined, true);
             // TODO should not be using `builtin` here. We should be using `all` instead.
             // The status report does not support `all` yet.
             statusReport[`analyze_builtin_queries_${language}_duration_ms`] =
-                new Date().getTime() - startTimeBuiltIn;
+                new Date().getTime() - startTimeRunQueries;
             logger.startGroup(`Interpreting results for ${language}`);
             const startTimeInterpretResults = new Date();
             const analysisSummary = await runInterpretResults(language, undefined, sarifFile, config.debugMode);

lib/analyze.test.js

@@ -39,12 +39,11 @@ const testing_utils_1 = require("./testing-utils");
 const uploadLib = __importStar(require("./upload-lib"));
 const util = __importStar(require("./util"));
 (0, testing_utils_1.setupTests)(ava_1.default);
-/** Checks that the duration fields are populated for the correct language
- * and correct case of builtin or custom. Also checks the correct search
- * paths are set in the database analyze invocation.
+/**
+ * Checks that the duration fields are populated for the correct language. Also checks the correct
+ * search paths are set in the database analyze invocation.
  *
- * Mocks the QA telemetry feature flag and checks the appropriate status report
- * fields.
+ * Mocks the QA telemetry feature flag and checks the appropriate status report fields.
  */
 (0, ava_1.default)("status report fields and search path setting", async (t) => {
     let searchPathsUsed = [];
@@ -122,13 +121,13 @@ const util = __importStar(require("./util"));
             fs.mkdirSync(util.getCodeQLDatabasePath(config, language), {
                 recursive: true,
             });
-            const builtinStatusReport = await (0, analyze_1.runQueries)(tmpDir, memoryFlag, addSnippetsFlag, threadsFlag, undefined, config, (0, logging_1.getRunnerLogger)(true), (0, testing_utils_1.createFeatures)([feature_flags_1.Feature.QaTelemetryEnabled]));
-            t.deepEqual(Object.keys(builtinStatusReport).sort(), [
+            const statusReport = await (0, analyze_1.runQueries)(tmpDir, memoryFlag, addSnippetsFlag, threadsFlag, undefined, config, (0, logging_1.getRunnerLogger)(true), (0, testing_utils_1.createFeatures)([feature_flags_1.Feature.QaTelemetryEnabled]));
+            t.deepEqual(Object.keys(statusReport).sort(), [
                 `analyze_builtin_queries_${language}_duration_ms`,
                 "event_reports",
                 `interpret_results_${language}_duration_ms`,
             ]);
-            for (const eventReport of builtinStatusReport.event_reports) {
+            for (const eventReport of statusReport.event_reports) {
                 t.deepEqual(eventReport.event, "codeql database interpret-results");
                 t.true("properties" in eventReport);
                 t.true("alertCounts" in eventReport.properties);