Fix typos
This commit is contained in:
parent
919e4caca1
commit
6c869f8b03
6 changed files with 9 additions and 9 deletions
|
|
@ -265,7 +265,7 @@ for (const featureFlag of Object.keys(featureConfig)) {
|
|||
// specify a minimum version, then we will have a bunch of code no longer being
|
||||
// tested. This is unlikely, and this test will fail if that happens.
|
||||
// If we do end up in that situation, then we should consider adding a synthetic
|
||||
// feature flag with a minium version that is only used for tests.
|
||||
// feature flag with a minimum version that is only used for tests.
|
||||
test("At least one feature has a minimum version specified", (t) => {
|
||||
t.assert(
|
||||
Object.values(featureConfig).some((f) => f.minimumVersion !== undefined),
|
||||
|
|
|
|||
|
|
@ -5,7 +5,7 @@ import { RepositoryNwo } from "./repository";
|
|||
import * as util from "./util";
|
||||
|
||||
export interface FeatureEnablement {
|
||||
getValue(feaature: Feature, codeql?: CodeQL): Promise<boolean>;
|
||||
getValue(feature: Feature, codeql?: CodeQL): Promise<boolean>;
|
||||
}
|
||||
|
||||
export enum Feature {
|
||||
|
|
@ -187,8 +187,8 @@ class GitHubFeatureFlags implements FeatureEnablement {
|
|||
`please ensure the Action has the 'security-events: write' permission. Details: ${e}`
|
||||
);
|
||||
} else {
|
||||
// Some feature, such as `ml_powered_queries_enabled` affect the produced alerts.
|
||||
// Considering these feature disabled in the event of a transient error could
|
||||
// Some features, such as `ml_powered_queries_enabled` affect the produced alerts.
|
||||
// Considering these features disabled in the event of a transient error could
|
||||
// therefore lead to alert churn. As a result, we crash if we cannot determine the value of
|
||||
// the feature.
|
||||
throw new Error(
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue