Address review, add test.
This commit is contained in:
parent
01fa64cb90
commit
75afbf4a30
6 changed files with 67 additions and 20 deletions
6
lib/feature-flags.js
generated
6
lib/feature-flags.js
generated
|
|
@ -40,12 +40,12 @@ class GitHubFeatureFlags {
|
|||
this.logger.debug(`No feature flags API response for ${flag}, considering it disabled.`);
|
||||
return false;
|
||||
}
|
||||
const flag_value = response[flag];
|
||||
if (flag_value === undefined) {
|
||||
const flagValue = response[flag];
|
||||
if (flagValue === undefined) {
|
||||
this.logger.debug(`Feature flag '${flag}' undefined in API response, considering it disabled.`);
|
||||
return false;
|
||||
}
|
||||
return flag_value;
|
||||
return flagValue;
|
||||
}
|
||||
async getApiResponse() {
|
||||
const loadApiResponse = async () => {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue