Apply suggestions from code review

Co-authored-by: Henry Mercer <henry.mercer@me.com>
This commit is contained in:
Michael B. Gale 2023-06-13 20:13:54 +01:00
parent ef4bf4ae03
commit 8e75e1a14d
No known key found for this signature in database
GPG key ID: FF5E2765BD00628F
9 changed files with 16 additions and 14 deletions

View file

@ -239,7 +239,6 @@ export interface ResolveQueriesOutput {
export interface ResolveBuildEnvironmentOutput {
configuration?: {
[language: string]: {
os?: unknown;
[key: string]: unknown;
};
};

View file

@ -2,6 +2,7 @@ import * as core from "@actions/core";
import {
createStatusReportBase,
getActionsStatus,
getOptionalInput,
getRequiredInput,
getTemporaryDirectory,
@ -58,11 +59,13 @@ async function run() {
core.setOutput("environment", result);
} catch (unwrappedError) {
const error = wrapError(unwrappedError);
core.setFailed(error.message);
core.setFailed(
`Failed to resolve a build environment suitable for automatically building your code. ${error.message}`
);
await sendStatusReport(
await createStatusReportBase(
ACTION_NAME,
"aborted",
getActionsStatus(error),
startedAt,
error.message,
error.stack

View file

@ -11,8 +11,8 @@ export async function runResolveBuildEnvironment(
logger.startGroup(
`Attempting to resolve build environment for ${language} in ${workingDir}`
);
const codeQL = await getCodeQL(cmd);
const result = await codeQL.resolveBuildEnvironment(workingDir, language);
const codeql = await getCodeQL(cmd);
const result = await codeql.resolveBuildEnvironment(workingDir, language);
logger.endGroup();
return result;
}