Bump the npm group with 5 updates (#1856)
* Bump the npm group with 5 updates Bumps the npm group with 5 updates: | Package | From | To | | --- | --- | --- | | [@types/semver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/semver) | `7.5.0` | `7.5.1` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.4.1` | `6.5.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.4.1` | `6.5.0` | | [eslint](https://github.com/eslint/eslint) | `8.47.0` | `8.48.0` | | [typescript](https://github.com/Microsoft/TypeScript) | `5.1.6` | `5.2.2` | Updates `@types/semver` from 7.5.0 to 7.5.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/semver) Updates `@typescript-eslint/eslint-plugin` from 6.4.1 to 6.5.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.5.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.4.1 to 6.5.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.5.0/packages/parser) Updates `eslint` from 8.47.0 to 8.48.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.47.0...v8.48.0) Updates `typescript` from 5.1.6 to 5.2.2 - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v5.1.6...v5.2.2) --- updated-dependencies: - dependency-name: "@types/semver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This commit is contained in:
parent
b88b5503aa
commit
8ecc33d259
72 changed files with 48141 additions and 37037 deletions
76
node_modules/eslint/lib/linter/code-path-analysis/code-path-segment.js
generated
vendored
76
node_modules/eslint/lib/linter/code-path-analysis/code-path-segment.js
generated
vendored
|
|
@ -1,5 +1,5 @@
|
|||
/**
|
||||
* @fileoverview A class of the code path segment.
|
||||
* @fileoverview The CodePathSegment class.
|
||||
* @author Toru Nagashima
|
||||
*/
|
||||
|
||||
|
|
@ -30,10 +30,22 @@ function isReachable(segment) {
|
|||
|
||||
/**
|
||||
* A code path segment.
|
||||
*
|
||||
* Each segment is arranged in a series of linked lists (implemented by arrays)
|
||||
* that keep track of the previous and next segments in a code path. In this way,
|
||||
* you can navigate between all segments in any code path so long as you have a
|
||||
* reference to any segment in that code path.
|
||||
*
|
||||
* When first created, the segment is in a detached state, meaning that it knows the
|
||||
* segments that came before it but those segments don't know that this new segment
|
||||
* follows it. Only when `CodePathSegment#markUsed()` is called on a segment does it
|
||||
* officially become part of the code path by updating the previous segments to know
|
||||
* that this new segment follows.
|
||||
*/
|
||||
class CodePathSegment {
|
||||
|
||||
/**
|
||||
* Creates a new instance.
|
||||
* @param {string} id An identifier.
|
||||
* @param {CodePathSegment[]} allPrevSegments An array of the previous segments.
|
||||
* This array includes unreachable segments.
|
||||
|
|
@ -49,27 +61,25 @@ class CodePathSegment {
|
|||
this.id = id;
|
||||
|
||||
/**
|
||||
* An array of the next segments.
|
||||
* An array of the next reachable segments.
|
||||
* @type {CodePathSegment[]}
|
||||
*/
|
||||
this.nextSegments = [];
|
||||
|
||||
/**
|
||||
* An array of the previous segments.
|
||||
* An array of the previous reachable segments.
|
||||
* @type {CodePathSegment[]}
|
||||
*/
|
||||
this.prevSegments = allPrevSegments.filter(isReachable);
|
||||
|
||||
/**
|
||||
* An array of the next segments.
|
||||
* This array includes unreachable segments.
|
||||
* An array of all next segments including reachable and unreachable.
|
||||
* @type {CodePathSegment[]}
|
||||
*/
|
||||
this.allNextSegments = [];
|
||||
|
||||
/**
|
||||
* An array of the previous segments.
|
||||
* This array includes unreachable segments.
|
||||
* An array of all previous segments including reachable and unreachable.
|
||||
* @type {CodePathSegment[]}
|
||||
*/
|
||||
this.allPrevSegments = allPrevSegments;
|
||||
|
|
@ -83,7 +93,11 @@ class CodePathSegment {
|
|||
// Internal data.
|
||||
Object.defineProperty(this, "internal", {
|
||||
value: {
|
||||
|
||||
// determines if the segment has been attached to the code path
|
||||
used: false,
|
||||
|
||||
// array of previous segments coming from the end of a loop
|
||||
loopedPrevSegments: []
|
||||
}
|
||||
});
|
||||
|
|
@ -113,9 +127,10 @@ class CodePathSegment {
|
|||
}
|
||||
|
||||
/**
|
||||
* Creates a segment that follows given segments.
|
||||
* Creates a new segment and appends it after the given segments.
|
||||
* @param {string} id An identifier.
|
||||
* @param {CodePathSegment[]} allPrevSegments An array of the previous segments.
|
||||
* @param {CodePathSegment[]} allPrevSegments An array of the previous segments
|
||||
* to append to.
|
||||
* @returns {CodePathSegment} The created segment.
|
||||
*/
|
||||
static newNext(id, allPrevSegments) {
|
||||
|
|
@ -127,7 +142,7 @@ class CodePathSegment {
|
|||
}
|
||||
|
||||
/**
|
||||
* Creates an unreachable segment that follows given segments.
|
||||
* Creates an unreachable segment and appends it after the given segments.
|
||||
* @param {string} id An identifier.
|
||||
* @param {CodePathSegment[]} allPrevSegments An array of the previous segments.
|
||||
* @returns {CodePathSegment} The created segment.
|
||||
|
|
@ -137,7 +152,7 @@ class CodePathSegment {
|
|||
|
||||
/*
|
||||
* In `if (a) return a; foo();` case, the unreachable segment preceded by
|
||||
* the return statement is not used but must not be remove.
|
||||
* the return statement is not used but must not be removed.
|
||||
*/
|
||||
CodePathSegment.markUsed(segment);
|
||||
|
||||
|
|
@ -157,7 +172,7 @@ class CodePathSegment {
|
|||
}
|
||||
|
||||
/**
|
||||
* Makes a given segment being used.
|
||||
* Marks a given segment as used.
|
||||
*
|
||||
* And this function registers the segment into the previous segments as a next.
|
||||
* @param {CodePathSegment} segment A segment to mark.
|
||||
|
|
@ -172,6 +187,13 @@ class CodePathSegment {
|
|||
let i;
|
||||
|
||||
if (segment.reachable) {
|
||||
|
||||
/*
|
||||
* If the segment is reachable, then it's officially part of the
|
||||
* code path. This loops through all previous segments to update
|
||||
* their list of next segments. Because the segment is reachable,
|
||||
* it's added to both `nextSegments` and `allNextSegments`.
|
||||
*/
|
||||
for (i = 0; i < segment.allPrevSegments.length; ++i) {
|
||||
const prevSegment = segment.allPrevSegments[i];
|
||||
|
||||
|
|
@ -179,6 +201,13 @@ class CodePathSegment {
|
|||
prevSegment.nextSegments.push(segment);
|
||||
}
|
||||
} else {
|
||||
|
||||
/*
|
||||
* If the segment is not reachable, then it's not officially part of the
|
||||
* code path. This loops through all previous segments to update
|
||||
* their list of next segments. Because the segment is not reachable,
|
||||
* it's added only to `allNextSegments`.
|
||||
*/
|
||||
for (i = 0; i < segment.allPrevSegments.length; ++i) {
|
||||
segment.allPrevSegments[i].allNextSegments.push(segment);
|
||||
}
|
||||
|
|
@ -196,19 +225,20 @@ class CodePathSegment {
|
|||
}
|
||||
|
||||
/**
|
||||
* Replaces unused segments with the previous segments of each unused segment.
|
||||
* @param {CodePathSegment[]} segments An array of segments to replace.
|
||||
* @returns {CodePathSegment[]} The replaced array.
|
||||
* Creates a new array based on an array of segments. If any segment in the
|
||||
* array is unused, then it is replaced by all of its previous segments.
|
||||
* All used segments are returned as-is without replacement.
|
||||
* @param {CodePathSegment[]} segments The array of segments to flatten.
|
||||
* @returns {CodePathSegment[]} The flattened array.
|
||||
*/
|
||||
static flattenUnusedSegments(segments) {
|
||||
const done = Object.create(null);
|
||||
const retv = [];
|
||||
const done = new Set();
|
||||
|
||||
for (let i = 0; i < segments.length; ++i) {
|
||||
const segment = segments[i];
|
||||
|
||||
// Ignores duplicated.
|
||||
if (done[segment.id]) {
|
||||
if (done.has(segment)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
|
|
@ -217,18 +247,16 @@ class CodePathSegment {
|
|||
for (let j = 0; j < segment.allPrevSegments.length; ++j) {
|
||||
const prevSegment = segment.allPrevSegments[j];
|
||||
|
||||
if (!done[prevSegment.id]) {
|
||||
done[prevSegment.id] = true;
|
||||
retv.push(prevSegment);
|
||||
if (!done.has(prevSegment)) {
|
||||
done.add(prevSegment);
|
||||
}
|
||||
}
|
||||
} else {
|
||||
done[segment.id] = true;
|
||||
retv.push(segment);
|
||||
done.add(segment);
|
||||
}
|
||||
}
|
||||
|
||||
return retv;
|
||||
return [...done];
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
45
node_modules/eslint/lib/rule-tester/flat-rule-tester.js
generated
vendored
45
node_modules/eslint/lib/rule-tester/flat-rule-tester.js
generated
vendored
|
|
@ -32,6 +32,7 @@ const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
|
|||
|
||||
/** @typedef {import("../shared/types").Parser} Parser */
|
||||
/** @typedef {import("../shared/types").LanguageOptions} LanguageOptions */
|
||||
/** @typedef {import("../shared/types").Rule} Rule */
|
||||
|
||||
|
||||
/**
|
||||
|
|
@ -446,7 +447,7 @@ class FlatRuleTester {
|
|||
/**
|
||||
* Adds a new rule test to execute.
|
||||
* @param {string} ruleName The name of the rule to run.
|
||||
* @param {Function} rule The rule to test.
|
||||
* @param {Function | Rule} rule The rule to test.
|
||||
* @param {{
|
||||
* valid: (ValidTestCase | string)[],
|
||||
* invalid: InvalidTestCase[]
|
||||
|
|
@ -1011,29 +1012,35 @@ class FlatRuleTester {
|
|||
/*
|
||||
* This creates a mocha test suite and pipes all supplied info through
|
||||
* one of the templates above.
|
||||
* The test suites for valid/invalid are created conditionally as
|
||||
* test runners (eg. vitest) fail for empty test suites.
|
||||
*/
|
||||
this.constructor.describe(ruleName, () => {
|
||||
this.constructor.describe("valid", () => {
|
||||
test.valid.forEach(valid => {
|
||||
this.constructor[valid.only ? "itOnly" : "it"](
|
||||
sanitize(typeof valid === "object" ? valid.name || valid.code : valid),
|
||||
() => {
|
||||
testValidTemplate(valid);
|
||||
}
|
||||
);
|
||||
if (test.valid.length > 0) {
|
||||
this.constructor.describe("valid", () => {
|
||||
test.valid.forEach(valid => {
|
||||
this.constructor[valid.only ? "itOnly" : "it"](
|
||||
sanitize(typeof valid === "object" ? valid.name || valid.code : valid),
|
||||
() => {
|
||||
testValidTemplate(valid);
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
this.constructor.describe("invalid", () => {
|
||||
test.invalid.forEach(invalid => {
|
||||
this.constructor[invalid.only ? "itOnly" : "it"](
|
||||
sanitize(invalid.name || invalid.code),
|
||||
() => {
|
||||
testInvalidTemplate(invalid);
|
||||
}
|
||||
);
|
||||
if (test.invalid.length > 0) {
|
||||
this.constructor.describe("invalid", () => {
|
||||
test.invalid.forEach(invalid => {
|
||||
this.constructor[invalid.only ? "itOnly" : "it"](
|
||||
sanitize(invalid.name || invalid.code),
|
||||
() => {
|
||||
testInvalidTemplate(invalid);
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
|
|
|||
50
node_modules/eslint/lib/rule-tester/rule-tester.js
generated
vendored
50
node_modules/eslint/lib/rule-tester/rule-tester.js
generated
vendored
|
|
@ -62,6 +62,7 @@ const { SourceCode } = require("../source-code");
|
|||
//------------------------------------------------------------------------------
|
||||
|
||||
/** @typedef {import("../shared/types").Parser} Parser */
|
||||
/** @typedef {import("../shared/types").Rule} Rule */
|
||||
|
||||
|
||||
/**
|
||||
|
|
@ -508,17 +509,20 @@ class RuleTester {
|
|||
/**
|
||||
* Define a rule for one particular run of tests.
|
||||
* @param {string} name The name of the rule to define.
|
||||
* @param {Function} rule The rule definition.
|
||||
* @param {Function | Rule} rule The rule definition.
|
||||
* @returns {void}
|
||||
*/
|
||||
defineRule(name, rule) {
|
||||
if (typeof rule === "function") {
|
||||
emitLegacyRuleAPIWarning(name);
|
||||
}
|
||||
this.rules[name] = rule;
|
||||
}
|
||||
|
||||
/**
|
||||
* Adds a new rule test to execute.
|
||||
* @param {string} ruleName The name of the rule to run.
|
||||
* @param {Function} rule The rule to test.
|
||||
* @param {Function | Rule} rule The rule to test.
|
||||
* @param {{
|
||||
* valid: (ValidTestCase | string)[],
|
||||
* invalid: InvalidTestCase[]
|
||||
|
|
@ -1021,29 +1025,35 @@ class RuleTester {
|
|||
/*
|
||||
* This creates a mocha test suite and pipes all supplied info through
|
||||
* one of the templates above.
|
||||
* The test suites for valid/invalid are created conditionally as
|
||||
* test runners (eg. vitest) fail for empty test suites.
|
||||
*/
|
||||
this.constructor.describe(ruleName, () => {
|
||||
this.constructor.describe("valid", () => {
|
||||
test.valid.forEach(valid => {
|
||||
this.constructor[valid.only ? "itOnly" : "it"](
|
||||
sanitize(typeof valid === "object" ? valid.name || valid.code : valid),
|
||||
() => {
|
||||
testValidTemplate(valid);
|
||||
}
|
||||
);
|
||||
if (test.valid.length > 0) {
|
||||
this.constructor.describe("valid", () => {
|
||||
test.valid.forEach(valid => {
|
||||
this.constructor[valid.only ? "itOnly" : "it"](
|
||||
sanitize(typeof valid === "object" ? valid.name || valid.code : valid),
|
||||
() => {
|
||||
testValidTemplate(valid);
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
this.constructor.describe("invalid", () => {
|
||||
test.invalid.forEach(invalid => {
|
||||
this.constructor[invalid.only ? "itOnly" : "it"](
|
||||
sanitize(invalid.name || invalid.code),
|
||||
() => {
|
||||
testInvalidTemplate(invalid);
|
||||
}
|
||||
);
|
||||
if (test.invalid.length > 0) {
|
||||
this.constructor.describe("invalid", () => {
|
||||
test.invalid.forEach(invalid => {
|
||||
this.constructor[invalid.only ? "itOnly" : "it"](
|
||||
sanitize(invalid.name || invalid.code),
|
||||
() => {
|
||||
testInvalidTemplate(invalid);
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
|
|
|||
23
node_modules/eslint/lib/rules/for-direction.js
generated
vendored
23
node_modules/eslint/lib/rules/for-direction.js
generated
vendored
|
|
@ -5,6 +5,12 @@
|
|||
|
||||
"use strict";
|
||||
|
||||
//------------------------------------------------------------------------------
|
||||
// Requirements
|
||||
//------------------------------------------------------------------------------
|
||||
|
||||
const { getStaticValue } = require("@eslint-community/eslint-utils");
|
||||
|
||||
//------------------------------------------------------------------------------
|
||||
// Rule Definition
|
||||
//------------------------------------------------------------------------------
|
||||
|
|
@ -29,6 +35,7 @@ module.exports = {
|
|||
},
|
||||
|
||||
create(context) {
|
||||
const { sourceCode } = context;
|
||||
|
||||
/**
|
||||
* report an error.
|
||||
|
|
@ -46,17 +53,17 @@ module.exports = {
|
|||
* check the right side of the assignment
|
||||
* @param {ASTNode} update UpdateExpression to check
|
||||
* @param {int} dir expected direction that could either be turned around or invalidated
|
||||
* @returns {int} return dir, the negated dir or zero if it's not clear for identifiers
|
||||
* @returns {int} return dir, the negated dir, or zero if the counter does not change or the direction is not clear
|
||||
*/
|
||||
function getRightDirection(update, dir) {
|
||||
if (update.right.type === "UnaryExpression") {
|
||||
if (update.right.operator === "-") {
|
||||
return -dir;
|
||||
}
|
||||
} else if (update.right.type === "Identifier") {
|
||||
return 0;
|
||||
const staticValue = getStaticValue(update.right, sourceCode.getScope(update));
|
||||
|
||||
if (staticValue && ["bigint", "boolean", "number"].includes(typeof staticValue.value)) {
|
||||
const sign = Math.sign(Number(staticValue.value)) || 0; // convert NaN to 0
|
||||
|
||||
return dir * sign;
|
||||
}
|
||||
return dir;
|
||||
return 0;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
|||
170
node_modules/eslint/lib/rules/no-promise-executor-return.js
generated
vendored
170
node_modules/eslint/lib/rules/no-promise-executor-return.js
generated
vendored
|
|
@ -10,6 +10,7 @@
|
|||
//------------------------------------------------------------------------------
|
||||
|
||||
const { findVariable } = require("@eslint-community/eslint-utils");
|
||||
const astUtils = require("./utils/ast-utils");
|
||||
|
||||
//------------------------------------------------------------------------------
|
||||
// Helpers
|
||||
|
|
@ -59,6 +60,78 @@ function isPromiseExecutor(node, scope) {
|
|||
isGlobalReference(parent.callee, getOuterScope(scope));
|
||||
}
|
||||
|
||||
/**
|
||||
* Checks if the given node is a void expression.
|
||||
* @param {ASTNode} node The node to check.
|
||||
* @returns {boolean} - `true` if the node is a void expression
|
||||
*/
|
||||
function expressionIsVoid(node) {
|
||||
return node.type === "UnaryExpression" && node.operator === "void";
|
||||
}
|
||||
|
||||
/**
|
||||
* Fixes the linting error by prepending "void " to the given node
|
||||
* @param {Object} sourceCode context given by context.sourceCode
|
||||
* @param {ASTNode} node The node to fix.
|
||||
* @param {Object} fixer The fixer object provided by ESLint.
|
||||
* @returns {Array<Object>} - An array of fix objects to apply to the node.
|
||||
*/
|
||||
function voidPrependFixer(sourceCode, node, fixer) {
|
||||
|
||||
const requiresParens =
|
||||
|
||||
// prepending `void ` will fail if the node has a lower precedence than void
|
||||
astUtils.getPrecedence(node) < astUtils.getPrecedence({ type: "UnaryExpression", operator: "void" }) &&
|
||||
|
||||
// check if there are parentheses around the node to avoid redundant parentheses
|
||||
!astUtils.isParenthesised(sourceCode, node);
|
||||
|
||||
// avoid parentheses issues
|
||||
const returnOrArrowToken = sourceCode.getTokenBefore(
|
||||
node,
|
||||
node.parent.type === "ArrowFunctionExpression"
|
||||
? astUtils.isArrowToken
|
||||
|
||||
// isReturnToken
|
||||
: token => token.type === "Keyword" && token.value === "return"
|
||||
);
|
||||
|
||||
const firstToken = sourceCode.getTokenAfter(returnOrArrowToken);
|
||||
|
||||
const prependSpace =
|
||||
|
||||
// is return token, as => allows void to be adjacent
|
||||
returnOrArrowToken.value === "return" &&
|
||||
|
||||
// If two tokens (return and "(") are adjacent
|
||||
returnOrArrowToken.range[1] === firstToken.range[0];
|
||||
|
||||
return [
|
||||
fixer.insertTextBefore(firstToken, `${prependSpace ? " " : ""}void ${requiresParens ? "(" : ""}`),
|
||||
fixer.insertTextAfter(node, requiresParens ? ")" : "")
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* Fixes the linting error by `wrapping {}` around the given node's body.
|
||||
* @param {Object} sourceCode context given by context.sourceCode
|
||||
* @param {ASTNode} node The node to fix.
|
||||
* @param {Object} fixer The fixer object provided by ESLint.
|
||||
* @returns {Array<Object>} - An array of fix objects to apply to the node.
|
||||
*/
|
||||
function curlyWrapFixer(sourceCode, node, fixer) {
|
||||
|
||||
// https://github.com/eslint/eslint/pull/17282#issuecomment-1592795923
|
||||
const arrowToken = sourceCode.getTokenBefore(node.body, astUtils.isArrowToken);
|
||||
const firstToken = sourceCode.getTokenAfter(arrowToken);
|
||||
const lastToken = sourceCode.getLastToken(node);
|
||||
|
||||
return [
|
||||
fixer.insertTextBefore(firstToken, "{"),
|
||||
fixer.insertTextAfter(lastToken, "}")
|
||||
];
|
||||
}
|
||||
|
||||
//------------------------------------------------------------------------------
|
||||
// Rule Definition
|
||||
//------------------------------------------------------------------------------
|
||||
|
|
@ -74,10 +147,27 @@ module.exports = {
|
|||
url: "https://eslint.org/docs/latest/rules/no-promise-executor-return"
|
||||
},
|
||||
|
||||
schema: [],
|
||||
hasSuggestions: true,
|
||||
|
||||
schema: [{
|
||||
type: "object",
|
||||
properties: {
|
||||
allowVoid: {
|
||||
type: "boolean",
|
||||
default: false
|
||||
}
|
||||
},
|
||||
additionalProperties: false
|
||||
}],
|
||||
|
||||
messages: {
|
||||
returnsValue: "Return values from promise executor functions cannot be read."
|
||||
returnsValue: "Return values from promise executor functions cannot be read.",
|
||||
|
||||
// arrow and function suggestions
|
||||
prependVoid: "Prepend `void` to the expression.",
|
||||
|
||||
// only arrow suggestions
|
||||
wrapBraces: "Wrap the expression in `{}`."
|
||||
}
|
||||
},
|
||||
|
||||
|
|
@ -85,26 +175,52 @@ module.exports = {
|
|||
|
||||
let funcInfo = null;
|
||||
const sourceCode = context.sourceCode;
|
||||
|
||||
/**
|
||||
* Reports the given node.
|
||||
* @param {ASTNode} node Node to report.
|
||||
* @returns {void}
|
||||
*/
|
||||
function report(node) {
|
||||
context.report({ node, messageId: "returnsValue" });
|
||||
}
|
||||
const {
|
||||
allowVoid = false
|
||||
} = context.options[0] || {};
|
||||
|
||||
return {
|
||||
|
||||
onCodePathStart(_, node) {
|
||||
funcInfo = {
|
||||
upper: funcInfo,
|
||||
shouldCheck: functionTypesToCheck.has(node.type) && isPromiseExecutor(node, sourceCode.getScope(node))
|
||||
shouldCheck:
|
||||
functionTypesToCheck.has(node.type) &&
|
||||
isPromiseExecutor(node, sourceCode.getScope(node))
|
||||
};
|
||||
|
||||
if (funcInfo.shouldCheck && node.type === "ArrowFunctionExpression" && node.expression) {
|
||||
report(node.body);
|
||||
if (// Is a Promise executor
|
||||
funcInfo.shouldCheck &&
|
||||
node.type === "ArrowFunctionExpression" &&
|
||||
node.expression &&
|
||||
|
||||
// Except void
|
||||
!(allowVoid && expressionIsVoid(node.body))
|
||||
) {
|
||||
const suggest = [];
|
||||
|
||||
// prevent useless refactors
|
||||
if (allowVoid) {
|
||||
suggest.push({
|
||||
messageId: "prependVoid",
|
||||
fix(fixer) {
|
||||
return voidPrependFixer(sourceCode, node.body, fixer);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
suggest.push({
|
||||
messageId: "wrapBraces",
|
||||
fix(fixer) {
|
||||
return curlyWrapFixer(sourceCode, node, fixer);
|
||||
}
|
||||
});
|
||||
|
||||
context.report({
|
||||
node: node.body,
|
||||
messageId: "returnsValue",
|
||||
suggest
|
||||
});
|
||||
}
|
||||
},
|
||||
|
||||
|
|
@ -113,9 +229,31 @@ module.exports = {
|
|||
},
|
||||
|
||||
ReturnStatement(node) {
|
||||
if (funcInfo.shouldCheck && node.argument) {
|
||||
report(node);
|
||||
if (!(funcInfo.shouldCheck && node.argument)) {
|
||||
return;
|
||||
}
|
||||
|
||||
// node is `return <expression>`
|
||||
if (!allowVoid) {
|
||||
context.report({ node, messageId: "returnsValue" });
|
||||
return;
|
||||
}
|
||||
|
||||
if (expressionIsVoid(node.argument)) {
|
||||
return;
|
||||
}
|
||||
|
||||
// allowVoid && !expressionIsVoid
|
||||
context.report({
|
||||
node,
|
||||
messageId: "returnsValue",
|
||||
suggest: [{
|
||||
messageId: "prependVoid",
|
||||
fix(fixer) {
|
||||
return voidPrependFixer(sourceCode, node.argument, fixer);
|
||||
}
|
||||
}]
|
||||
});
|
||||
}
|
||||
};
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue