Address PR comments from @robertbrignull

This commit is contained in:
Edoardo Pirovano 2021-07-26 13:46:10 +01:00 committed by Edoardo Pirovano
parent e145aa414e
commit 934fb86c58
5 changed files with 11 additions and 14 deletions

View file

@ -27,7 +27,7 @@ jobs:
run: .github/workflows/script/check-js.sh
check-node-modules:
runs-on: ubuntu-latest
runs-on: macos-latest
steps:
- uses: actions/checkout@v2

View file

@ -7,6 +7,7 @@ if [ ! -z "$(git status --porcelain)" ]; then
>&2 echo "Failed: Repo should be clean before testing!"
exit 1
fi
sudo npm install --force -g npm@latest
# Reinstall modules and then clean to remove absolute paths
# Use 'npm ci' instead of 'npm install' as this is intended to be reproducible
npm ci

View file

@ -1,6 +1,7 @@
name: Update dependencies
on:
pull_request:
pull_request_target:
types: [opened, synchronize, reopened, labeled]
jobs:
update:
@ -32,6 +33,9 @@ jobs:
git config --global user.email "github-actions@github.com"
git config --global user.name "github-actions[bot]"
git add node_modules
git commit -am "Update checked-in dependencies"
git push
if ! git commit -am "Update checked-in dependencies" ; then
echo "No changes detected, skipping pushing..."
exit 0
fi
git push origin "$BRANCH"

6
node_modules/.package-lock.json generated vendored
View file

@ -1,6 +1,6 @@
{
"name": "codeql",
"version": "1.0.6",
"version": "1.0.8",
"lockfileVersion": 2,
"requires": true,
"packages": {
@ -1243,7 +1243,6 @@
"dependencies": {
"anymatch": "~3.1.1",
"braces": "~3.0.2",
"fsevents": "~2.1.2",
"glob-parent": "~5.1.0",
"is-binary-path": "~2.1.0",
"is-glob": "~4.0.1",
@ -3220,9 +3219,6 @@
"node_modules/jsonfile": {
"version": "4.0.0",
"license": "MIT",
"dependencies": {
"graceful-fs": "^4.1.6"
},
"optionalDependencies": {
"graceful-fs": "^4.1.6"
}

6
package-lock.json generated
View file

@ -6,7 +6,7 @@
"packages": {
"": {
"name": "codeql",
"version": "1.0.6",
"version": "1.0.8",
"license": "MIT",
"dependencies": {
"@actions/artifact": "^0.5.1",
@ -1297,7 +1297,6 @@
"dependencies": {
"anymatch": "~3.1.1",
"braces": "~3.0.2",
"fsevents": "~2.1.2",
"glob-parent": "~5.1.0",
"is-binary-path": "~2.1.0",
"is-glob": "~4.0.1",
@ -3274,9 +3273,6 @@
"node_modules/jsonfile": {
"version": "4.0.0",
"license": "MIT",
"dependencies": {
"graceful-fs": "^4.1.6"
},
"optionalDependencies": {
"graceful-fs": "^4.1.6"
}