Address PR comments from @robertbrignull

This commit is contained in:
Edoardo Pirovano 2021-07-26 13:46:10 +01:00 committed by Edoardo Pirovano
parent e145aa414e
commit 934fb86c58
5 changed files with 11 additions and 14 deletions

View file

@ -27,7 +27,7 @@ jobs:
run: .github/workflows/script/check-js.sh
check-node-modules:
runs-on: ubuntu-latest
runs-on: macos-latest
steps:
- uses: actions/checkout@v2

View file

@ -7,6 +7,7 @@ if [ ! -z "$(git status --porcelain)" ]; then
>&2 echo "Failed: Repo should be clean before testing!"
exit 1
fi
sudo npm install --force -g npm@latest
# Reinstall modules and then clean to remove absolute paths
# Use 'npm ci' instead of 'npm install' as this is intended to be reproducible
npm ci

View file

@ -1,6 +1,7 @@
name: Update dependencies
on:
pull_request:
pull_request_target:
types: [opened, synchronize, reopened, labeled]
jobs:
update:
@ -32,6 +33,9 @@ jobs:
git config --global user.email "github-actions@github.com"
git config --global user.name "github-actions[bot]"
git add node_modules
git commit -am "Update checked-in dependencies"
git push
if ! git commit -am "Update checked-in dependencies" ; then
echo "No changes detected, skipping pushing..."
exit 0
fi
git push origin "$BRANCH"