robojerk/codeql-action

feat: classify more HTTP errors as configuration errors in api-client

Browse source
This commit is contained in:
Fotis Koutoulakis (@NlightNFotis) 2025-03-31 11:54:16 +01:00
parent 3c42562190
commit a022653e2d
6 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/api-client.js generated
View file

@ -206,6 +206,9 @@ function wrapApiConfigurationError(e) {
if ((0, util_1.isHTTPError)(e)) {
if (e.message.includes("API rate limit exceeded for installation") ||
e.message.includes("commit not found") ||
e.message.includes("Bad credentials") ||
e.message.includes("Not Found") ||
e.message.includes("Resource not accessible by integration") ||
/ref .* not found in this repository/.test(e.message)) {
return new util_1.ConfigurationError(e.message);
}

2
lib/api-client.js.map
View file

File diff suppressed because one or more lines are too long

9
lib/api-client.test.js generated
View file

@ -145,5 +145,14 @@ function mockGetMetaVersionHeader(versionHeader) {
const apiRateLimitError = new util.HTTPError("API rate limit exceeded for installation", 403);
res = api.wrapApiConfigurationError(apiRateLimitError);
t.deepEqual(res, new util.ConfigurationError("API rate limit exceeded for installation"));
const badCredentialsError = new util.HTTPError("Bad credentials", 401);
res = api.wrapApiConfigurationError(badCredentialsError);
t.deepEqual(res, new util.ConfigurationError("Bad credentials"));
const notFoundError = new util.HTTPError("Not Found", 404);
res = api.wrapApiConfigurationError(notFoundError);
t.deepEqual(res, new util.ConfigurationError("Not Found"));
const resourceNotAccessibleError = new util.HTTPError("Resource not accessible by integration", 403);
res = api.wrapApiConfigurationError(resourceNotAccessibleError);
t.deepEqual(res, new util.ConfigurationError("Resource not accessible by integration"));
});
//# sourceMappingURL=api-client.test.js.map

2
lib/api-client.test.js.map
View file

File diff suppressed because one or more lines are too long