Remove 2.12.6 from tests

pr-checks/checks/diagnostics-export.yml

@@ -1,8 +1,6 @@
 name: "Diagnostic export"
 description: "Tests that manually added diagnostics are correctly exported to SARIF."
-# Test on 2.12.6 (which requires a workaround in the Action), the latest release, and the latest
-# nightly.
-versions: ["stable-20230403", "linked", "nightly-latest"]
+versions: ["linked", "nightly-latest"]
 env:
   CODEQL_ACTION_EXPORT_DIAGNOSTICS: true
 steps:
@@ -16,17 +14,13 @@ steps:
     env:
       CODEQL_PATH: ${{ steps.init.outputs.codeql-path }}
     run: |
-      for i in {1..2}; do
-        # Use the same location twice to test the workaround for the bug in CodeQL CLI 2.12.6 that
-        # produces an invalid diagnostic with multiple identical location objects.
-        "$CODEQL_PATH" database add-diagnostic \
-          "$RUNNER_TEMP/codeql_databases/javascript" \
-          --file-path /path/to/file \
-          --plaintext-message "Plaintext message $i" \
-          --source-id "lang/diagnostics/example" \
-          --source-name "Diagnostic name" \
-          --ready-for-status-page
-      done
+      "$CODEQL_PATH" database add-diagnostic \
+        "$RUNNER_TEMP/codeql_databases/javascript" \
+        --file-path /path/to/file \
+        --plaintext-message "Plaintext message" \
+        --source-id "lang/diagnostics/example" \
+        --source-name "Diagnostic name" \
+        --ready-for-status-page
   - uses: ./../action/analyze
     with:
       output: "${{ runner.temp }}/results"
@@ -46,7 +40,7 @@ steps:
         const fs = require('fs');
 
         function checkStatusPageNotification(n) {
-          const expectedMessage = 'Plaintext message 1\n\nCodeQL also found 1 other diagnostic like this. See the workflow log for details.';
+          const expectedMessage = 'Plaintext message';
           if (n.message.text !== expectedMessage) {
             core.setFailed(`Expected the status page diagnostic to have the message '${expectedMessage}', but found '${n.message.text}'.`);
           }

pr-checks/checks/multi-language-autodetect.yml

@@ -68,7 +68,7 @@ steps:
       fi
 
   - name: Check language autodetect for Swift on MacOS
-    if: runner.os == 'macOS' && matrix.version != 'stable-20230403'
+    if: runner.os == 'macOS'
     shell: bash
     run: |
       SWIFT_DB=${{ fromJson(steps.analysis.outputs.db-locations).swift }}

pr-checks/checks/resolve-environment-action.yml

@@ -1,10 +1,10 @@
 name: "Resolve environment"
 description: "Tests that the resolve-environment action works for Go and JavaScript/TypeScript"
-versions: ["stable-v2.13.4", "default", "linked", "nightly-latest"]
+versions: ["stable-v2.13.5", "default", "linked", "nightly-latest"]
 steps:
   - uses: ./../action/init
     with:
-      languages: ${{ matrix.version == 'stable-v2.13.4' && 'go' || 'go,javascript-typescript' }}
+      languages: ${{ matrix.version == 'stable-v2.13.5' && 'go' || 'go,javascript-typescript' }}
       tools: ${{ steps.prepare-test.outputs.tools-url }}
 
   - name: Resolve environment for Go
@@ -18,12 +18,12 @@ steps:
     run: exit 1
 
   - name: Resolve environment for JavaScript/TypeScript
-    if: matrix.version != 'stable-v2.13.4'
+    if: matrix.version != 'stable-v2.13.5'
     uses: ./../action/resolve-environment
     id: resolve-environment-js
     with:
       language: javascript-typescript
 
   - name: Fail if JavaScript/TypeScript configuration present
-    if: matrix.version != 'stable-v2.13.4' && fromJSON(steps.resolve-environment-js.outputs.environment).configuration.javascript
+    if: matrix.version != 'stable-v2.13.5' && fromJSON(steps.resolve-environment-js.outputs.environment).configuration.javascript
     run: exit 1

pr-checks/sync.py

@@ -7,15 +7,13 @@ import textwrap
 
 # The default set of CodeQL Bundle versions to use for the PR checks.
 defaultTestVersions = [
-    # The oldest supported CodeQL version: 2.12.6. If bumping, update `CODEQL_MINIMUM_VERSION` in `codeql.ts`
-    "stable-20230403",
-    # The last CodeQL release in the 2.13 series: 2.13.5.
+    # The oldest supported CodeQL version. If bumping, update `CODEQL_MINIMUM_VERSION` in `codeql.ts`
     "stable-v2.13.5",
-    # The last CodeQL release in the 2.14 series: 2.14.6.
+    # The last CodeQL release in the 2.14 series.
     "stable-v2.14.6",
-    # The last CodeQL release in the 2.15 series: 2.15.5.
+    # The last CodeQL release in the 2.15 series.
     "stable-v2.15.5",
-    # The last CodeQL release in the 2.16 series: 2.16.6.
+    # The last CodeQL release in the 2.16 series.
     "stable-v2.16.6",
     # The default version of CodeQL for Dotcom, as determined by feature flags.
     "default",
@@ -78,7 +76,7 @@ for file in (this_dir / 'checks').glob('*.yml'):
 
                 # Prior to CLI v2.15.1, ARM runners were not supported by the build tracer.
                 # "macos-latest" is now an ARM runner, so we run tests on the old CLIs on Intel runners instead.
-                if version in ["stable-20230403", "stable-v2.13.4", "stable-v2.13.5", "stable-v2.14.6"] and runnerImage == "macos-latest":
+                if version in ["stable-v2.13.4", "stable-v2.13.5", "stable-v2.14.6"] and runnerImage == "macos-latest":
                     matrix.append({
                         'os': "macos-12",
                         'version': version
@@ -101,7 +99,6 @@ for file in (this_dir / 'checks').glob('*.yml'):
             # of the generated workflow.
             'if': FoldedScalarString(textwrap.dedent('''
                     runner.os == 'macOS' && (
-                    matrix.version == 'stable-20230403' ||
                     matrix.version == 'stable-v2.13.5' ||
                     matrix.version == 'stable-v2.14.6')
             ''').strip()),