Address comments from review

- Change env var name for `MlPoweredQueriesEnabled`
- Throw error if minimumVersion is specified, but CodeQL argument is not
  supplied.
- Fix failing tests. Note that I removed a config-utils test because it
  is no longer relevant since we handle codeql minimum versions in the
  `getValue` function.
This commit is contained in:
Andrew Eisenberg 2022-10-06 12:29:58 -07:00
parent e5c3375225
commit b16314e16c
9 changed files with 202 additions and 129 deletions

View file

@ -1971,15 +1971,6 @@ const mlPoweredQueriesMacro = test.macro({
});
// macro, codeQLVersion, isMlPoweredQueriesFlagEnabled, packsInput, queriesInput, expectedVersionString
// Test that ML-powered queries aren't run on v2.7.4 of the CLI.
test(
mlPoweredQueriesMacro,
"2.7.4",
true,
undefined,
"security-extended",
undefined
);
// Test that ML-powered queries aren't run when the feature flag is off.
test(
mlPoweredQueriesMacro,