robojerk/codeql-action

Use GITHUB_DOTCOM_URL so URL deduplication works

Browse source
This commit is contained in:
Robert Brignull 2020-10-05 16:44:43 +01:00
parent 28a5b954e7
commit b185050563
6 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/util.test.ts
View file

@ -125,15 +125,15 @@ test("getExtraOptionsEnvParam() fails on invalid JSON", (t) => {
});
test("parseGithubUrl", (t) => {
t.deepEqual(util.parseGithubUrl("github.com"), "https://github.com/");
t.deepEqual(util.parseGithubUrl("https://github.com"), "https://github.com/");
t.deepEqual(util.parseGithubUrl("github.com"), "https://github.com");
t.deepEqual(util.parseGithubUrl("https://github.com"), "https://github.com");
t.deepEqual(
util.parseGithubUrl("https://api.github.com"),
"https://github.com/"
"https://github.com"
);
t.deepEqual(
util.parseGithubUrl("https://github.com/foo/bar"),
"https://github.com/"
"https://github.com"
);
t.deepEqual(

2
src/util.ts
View file

@ -189,7 +189,7 @@ export function parseGithubUrl(inputUrl: string): string {
// If we detect this is trying to be to github.com
// then return with a fixed canonical URL.
if (url.hostname === "github.com" || url.hostname === "api.github.com") {
return "https://github.com/";
return GITHUB_DOTCOM_URL;
}
// Remove the API prefix if it's present