robojerk/codeql-action

Hide error message and stack for non-error

Browse source 
Avoid printing the error message and stack when we fail to find the
commit. This will happen in several non-error states (e.g.,
when there is no repository checked out at the CWD). Move the
error message to a debug message so that it is still available
if someone really wants to see it.
This commit is contained in:
Andrew Eisenberg 2023-01-17 15:00:24 -08:00
parent 32be38eeff
commit b625b628b7
3 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/actions-util.js generated
View file

@ -88,8 +88,9 @@ const getCommitOid = async function (checkoutPath, ref = "HEAD") {
return commitOid.trim();
}
catch (e) {
core.info(`Failed to call git to get current commit. Continuing with data from environment or input: ${e}`);
core.info(e.stack || "NO STACK");
core.info("Could not determine current commit SHA. Continuing with data from the environment.");
core.debug(`Reason: ${e.message}`);
core.debug(e.stack || "NO STACK");
return (0, exports.getOptionalInput)("sha") || (0, util_1.getRequiredEnvParam)("GITHUB_SHA");
}
};

2
lib/actions-util.js.map
View file

File diff suppressed because one or more lines are too long

5
src/actions-util.ts
View file

@ -88,9 +88,10 @@ export const getCommitOid = async function (
return commitOid.trim();
} catch (e) {
core.info(
`Failed to call git to get current commit. Continuing with data from environment or input: ${e}`
"Could not determine current commit SHA. Continuing with data from the environment."
);
core.info((e as Error).stack || "NO STACK");
core.debug(`Reason: ${(e as Error).message}`);
core.debug((e as Error).stack || "NO STACK");
return getOptionalInput("sha") || getRequiredEnvParam("GITHUB_SHA");
}
};