robojerk/codeql-action

Clone packs from configuration to prevent modifications

Browse source
This commit is contained in:
Remco Vermeulen 2024-07-31 17:56:53 -07:00
parent 7be3a64c02
commit ba3ac6f096
3 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/init-action.js generated
View file

@ -87,12 +87,14 @@ async function sendCompletedStatusReport(startedAt, config, toolsDownloadDuratio
if ((config.augmentationProperties.packsInputCombines || if ((config.augmentationProperties.packsInputCombines ||
!config.augmentationProperties.packsInput) && !config.augmentationProperties.packsInput) &&
config.originalUserInput.packs) { config.originalUserInput.packs) {
// Make a copy, because we might modify `packs`.
const copyPacksFromOriginalUserInput = (0, util_1.cloneObject)(config.originalUserInput.packs);
// If it is an array, then assume there is only a single language being analyzed. // If it is an array, then assume there is only a single language being analyzed.
if (Array.isArray(config.originalUserInput.packs)) { if (Array.isArray(copyPacksFromOriginalUserInput)) {
packs[config.languages[0]] = config.originalUserInput.packs; packs[config.languages[0]] = copyPacksFromOriginalUserInput;
} }
else { else {
packs = config.originalUserInput.packs; packs = copyPacksFromOriginalUserInput;
} }
} }
if (config.augmentationProperties.packsInput) { if (config.augmentationProperties.packsInput) {

2
lib/init-action.js.map
View file

File diff suppressed because one or more lines are too long

11
src/init-action.ts
View file

@ -60,6 +60,7 @@ import {
ConfigurationError, ConfigurationError,
wrapError, wrapError,
checkActionVersion, checkActionVersion,
cloneObject,
} from "./util"; } from "./util";
import { validateWorkflow } from "./workflow"; import { validateWorkflow } from "./workflow";
@ -187,11 +188,15 @@ async function sendCompletedStatusReport(
!config.augmentationProperties.packsInput) && !config.augmentationProperties.packsInput) &&
config.originalUserInput.packs config.originalUserInput.packs
) { ) {
// Make a copy, because we might modify `packs`.
const copyPacksFromOriginalUserInput = cloneObject(
config.originalUserInput.packs,
);
// If it is an array, then assume there is only a single language being analyzed. // If it is an array, then assume there is only a single language being analyzed.
if (Array.isArray(config.originalUserInput.packs)) { if (Array.isArray(copyPacksFromOriginalUserInput)) {
packs[config.languages[0]] = config.originalUserInput.packs; packs[config.languages[0]] = copyPacksFromOriginalUserInput;
} else { } else {
packs = config.originalUserInput.packs; packs = copyPacksFromOriginalUserInput;
} }
} }