robojerk/codeql-action

Remove parameters from uploadFromActions

Browse source 
Retrieve the relevant values in the method itself instead.
This commit is contained in:
Sam Partington 2021-01-28 15:37:09 +00:00
parent 74004631ca
commit c2377b2e49
9 changed files with 29 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/upload-lib.ts
View file

@ -7,10 +7,11 @@ import fileUrl from "file-url";
import * as jsonschema from "jsonschema";
import * as semver from "semver";
import * as actionsUtil from "./actions-util";
import * as api from "./api-client";
import * as fingerprints from "./fingerprints";
import { Logger } from "./logging";
import { RepositoryNwo } from "./repository";
import { parseRepositoryNwo, RepositoryNwo } from "./repository";
import * as sharedEnv from "./shared-environment";
import * as util from "./util";
@ -104,18 +105,21 @@ export function findSarifFilesInDir(sarifPath: string): string[] {
// Returns true iff the upload occurred and succeeded
export async function uploadFromActions(
sarifPath: string,
repositoryNwo: RepositoryNwo,
commitOid: string,
ref: string,
analysisKey: string,
analysisName: string,
workflowRunID: number,
checkoutPath: string,
environment: string,
gitHubVersion: util.GitHubVersion,
apiDetails: api.GitHubApiDetails,
logger: Logger
): Promise<UploadStatusReport> {
const repositoryNwo = parseRepositoryNwo(
actionsUtil.getRequiredEnvParam("GITHUB_REPOSITORY")
);
const commitOid = await actionsUtil.getCommitOid();
const ref = await actionsUtil.getRef();
const analysisKey = await actionsUtil.getAnalysisKey();
const analysisName = actionsUtil.getRequiredEnvParam("GITHUB_WORKFLOW");
const workflowRunID = actionsUtil.getWorkflowRunID();
const checkoutPath = actionsUtil.getRequiredInput("checkout_path");
const environment = actionsUtil.getRequiredInput("matrix");
return await uploadFiles(
getSarifFilePaths(sarifPath),
repositoryNwo,