Soften deprecation message wording and remove unhelpful version strings from some locations

This commit is contained in:
Fotis Koutoulakis (@NlightNFotis) 2024-05-13 11:39:50 +01:00 committed by Fotis Koutoulakis
parent bcc13653e8
commit df4819e3a1
6 changed files with 38 additions and 26 deletions

View file

@ -103,7 +103,7 @@ ava_1.default.beforeEach(() => {
t.is(source.toolsVersion, testing_utils_1.LINKED_CLI_VERSION.cliVersion);
t.is(source.sourceType, "download");
// Afterwards, ensure that we see the deprecation message in the log.
const expected_message = "The 'latest' alias for the CodeQL tools has been deprecated. Please use 'linked' instead.";
const expected_message = "`tools: latest` has been renamed to `tools: linked`, but the old name is still supported for now. No action is required.";
t.assert(loggedMessages.some((msg) => typeof msg.message === "string" &&
msg.message.includes(expected_message)));
});
@ -149,7 +149,7 @@ ava_1.default.beforeEach(() => {
// bundle contains..
t.is(result.toolsVersion, expectedVersion);
// Ensure message logging CodeQL CLI version was present in user logs.
const expected_message = `Using CodeQL CLI version 2.16.0 downloaded from ${bundleUrl}.`;
const expected_message = `Using CodeQL CLI version 2.16.0 sourced from ${bundleUrl}.`;
t.assert(loggedMessages.some((msg) => typeof msg.message === "string" &&
msg.message.includes(expected_message)));
});