robojerk/codeql-action

Only report the first CheckoutWrongHead lint error

Browse source
This commit is contained in:
Simon Engledew 2020-12-21 10:55:55 +00:00
parent dc999c55d0
commit e89a24b8cb
No known key found for this signature in database
GPG key ID: 84302E7B02FE8BCE
6 changed files with 50 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/actions-util.ts
View file

@ -212,7 +212,7 @@ export function validateWorkflow(doc: Workflow): CodedError[] {
const errors: CodedError[] = [];
// .jobs[key].steps[].run
for (const job of Object.values(doc?.jobs || {})) {
outer: for (const job of Object.values(doc?.jobs || {})) {
if (Array.isArray(job?.steps)) {
for (const step of job?.steps) {
// this was advice that we used to give in the README
@ -222,6 +222,7 @@ export function validateWorkflow(doc: Workflow): CodedError[] {
// and avoid some race conditions
if (step?.run === "git checkout HEAD^2") {
errors.push(WorkflowErrors.CheckoutWrongHead);
break outer;
}
}
}